From fab88884b7365f184cfe87e6976242da661b8c55 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Tue, 24 Mar 2026 15:20:52 +0100 Subject: [PATCH] refactor: Avoid manual chrono casts with * or / Manual chrono casts, using multiplication or division is confusing and brittle. Also, when calling ShouldRunInactivityChecks remove a confusing and useless std::chrono::duration_cast. --- src/net_processing.cpp | 4 ++-- src/qt/guiutil.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 6377e3fac3d..d9cf3920e0e 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -5398,13 +5398,13 @@ void PeerManagerImpl::CheckForStaleTipAndEvictPeers() void PeerManagerImpl::MaybeSendPing(CNode& node_to, Peer& peer, std::chrono::microseconds now) { - if (m_connman.ShouldRunInactivityChecks(node_to, std::chrono::duration_cast(now)) && + if (m_connman.ShouldRunInactivityChecks(node_to, now) && peer.m_ping_nonce_sent && now > peer.m_ping_start.load() + TIMEOUT_INTERVAL) { // The ping timeout is using mocktime. To disable the check during // testing, increase -peertimeout. - LogDebug(BCLog::NET, "ping timeout: %fs, %s", 0.000001 * count_microseconds(now - peer.m_ping_start.load()), node_to.DisconnectMsg()); + LogDebug(BCLog::NET, "ping timeout: %fs, %s", Ticks(now - peer.m_ping_start.load()), node_to.DisconnectMsg()); node_to.fDisconnect = true; return; } diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp index 1619227a419..9fd46cfc1e1 100644 --- a/src/qt/guiutil.cpp +++ b/src/qt/guiutil.cpp @@ -771,7 +771,7 @@ QString formatPingTime(std::chrono::microseconds ping_time) { return (ping_time == std::chrono::microseconds::max() || ping_time == 0us) ? QObject::tr("N/A") : - QObject::tr("%1 ms").arg(QString::number((int)(count_microseconds(ping_time) / 1000), 10)); + QObject::tr("%1 ms").arg(QString::number(Ticks(ping_time))); } QString formatTimeOffset(int64_t time_offset)