From fad2faf6c5d8f09a91fb291e30b4989b06a6fe86 Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Fri, 16 May 2025 09:30:13 +0200
Subject: [PATCH] fuzz: Delete wallet_notifications

---
 src/wallet/test/fuzz/CMakeLists.txt    |   1 -
 src/wallet/test/fuzz/notifications.cpp | 173 -------------------------
 2 files changed, 174 deletions(-)
 delete mode 100644 src/wallet/test/fuzz/notifications.cpp

diff --git a/src/wallet/test/fuzz/CMakeLists.txt b/src/wallet/test/fuzz/CMakeLists.txt
index c290927c09f..3610a0f20a0 100644
--- a/src/wallet/test/fuzz/CMakeLists.txt
+++ b/src/wallet/test/fuzz/CMakeLists.txt
@@ -8,7 +8,6 @@ target_sources(fuzz
     coinselection.cpp
     crypter.cpp
     fees.cpp
-    notifications.cpp
     scriptpubkeyman.cpp
     spend.cpp
     wallet_bdb_parser.cpp
diff --git a/src/wallet/test/fuzz/notifications.cpp b/src/wallet/test/fuzz/notifications.cpp
deleted file mode 100644
index b1302e3b35d..00000000000
--- a/src/wallet/test/fuzz/notifications.cpp
+++ /dev/null
@@ -1,173 +0,0 @@
-// Copyright (c) 2021-present The Bitcoin Core developers
-// Distributed under the MIT software license, see the accompanying
-// file COPYING or http://www.opensource.org/licenses/mit-license.php.
-
-#include <addresstype.h>
-#include <consensus/amount.h>
-#include <interfaces/chain.h>
-#include <kernel/chain.h>
-#include <outputtype.h>
-#include <policy/feerate.h>
-#include <policy/policy.h>
-#include <primitives/block.h>
-#include <primitives/transaction.h>
-#include <script/descriptor.h>
-#include <script/script.h>
-#include <script/signingprovider.h>
-#include <sync.h>
-#include <test/fuzz/FuzzedDataProvider.h>
-#include <test/fuzz/fuzz.h>
-#include <test/fuzz/util.h>
-#include <test/fuzz/util/wallet.h>
-#include <test/util/setup_common.h>
-#include <tinyformat.h>
-#include <uint256.h>
-#include <util/check.h>
-#include <util/result.h>
-#include <util/time.h>
-#include <util/translation.h>
-#include <wallet/coincontrol.h>
-#include <wallet/context.h>
-#include <wallet/fees.h>
-#include <wallet/receive.h>
-#include <wallet/spend.h>
-#include <wallet/test/util.h>
-#include <wallet/wallet.h>
-#include <wallet/walletutil.h>
-
-#include <cstddef>
-#include <cstdint>
-#include <limits>
-#include <numeric>
-#include <set>
-#include <string>
-#include <tuple>
-#include <utility>
-#include <vector>
-
-namespace wallet {
-namespace {
-const TestingSetup* g_setup;
-
-void initialize_setup()
-{
-    static const auto testing_setup = MakeNoLogFileContext<const TestingSetup>();
-    g_setup = testing_setup.get();
-}
-
-FUZZ_TARGET(wallet_notifications, .init = initialize_setup)
-{
-    SeedRandomStateForTest(SeedRand::ZEROS);
-    FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
-    SetMockTime(ConsumeTime(fuzzed_data_provider));
-    // The total amount, to be distributed to the wallets a and b in txs
-    // without fee. Thus, the balance of the wallets should always equal the
-    // total amount.
-    const auto total_amount{ConsumeMoney(fuzzed_data_provider, /*max=*/MAX_MONEY / 100000)};
-    FuzzedWallet a{
-        *g_setup->m_node.chain,
-        "fuzzed_wallet_a",
-        "tprv8ZgxMBicQKsPd1QwsGgzfu2pcPYbBosZhJknqreRHgsWx32nNEhMjGQX2cgFL8n6wz9xdDYwLcs78N4nsCo32cxEX8RBtwGsEGgybLiQJfk",
-    };
-    FuzzedWallet b{
-        *g_setup->m_node.chain,
-        "fuzzed_wallet_b",
-        "tprv8ZgxMBicQKsPfCunYTF18sEmEyjz8TfhGnZ3BoVAhkqLv7PLkQgmoG2Ecsp4JuqciWnkopuEwShit7st743fdmB9cMD4tznUkcs33vK51K9",
-    };
-
-    // Keep track of all coins in this test.
-    // Each tuple in the chain represents the coins and the block created with
-    // those coins. Once the block is mined, the next tuple will have an empty
-    // block and the freshly mined coins.
-    using Coins = std::set<std::tuple<CAmount, COutPoint>>;
-    std::vector<std::tuple<Coins, CBlock>> chain;
-    {
-        // Add the initial entry
-        chain.emplace_back();
-        auto& [coins, block]{chain.back()};
-        coins.emplace(total_amount, COutPoint{Txid::FromUint256(uint256::ONE), 1});
-    }
-    LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 20)
-    {
-        CallOneOf(
-            fuzzed_data_provider,
-            [&] {
-                auto& [coins_orig, block]{chain.back()};
-                // Copy the coins for this block and consume all of them
-                Coins coins = coins_orig;
-                while (!coins.empty()) {
-                    // Create a new tx
-                    CMutableTransaction tx{};
-                    // Add some coins as inputs to it
-                    auto num_inputs{fuzzed_data_provider.ConsumeIntegralInRange<int>(1, coins.size())};
-                    CAmount in{0};
-                    while (num_inputs-- > 0) {
-                        const auto& [coin_amt, coin_outpoint]{*coins.begin()};
-                        in += coin_amt;
-                        tx.vin.emplace_back(coin_outpoint);
-                        coins.erase(coins.begin());
-                    }
-                    // Create some outputs spending all inputs, without fee
-                    LIMITED_WHILE(in > 0 && fuzzed_data_provider.ConsumeBool(), 10)
-                    {
-                        const auto out_value{ConsumeMoney(fuzzed_data_provider, in)};
-                        in -= out_value;
-                        auto& wallet{fuzzed_data_provider.ConsumeBool() ? a : b};
-                        tx.vout.emplace_back(out_value, wallet.GetScriptPubKey(fuzzed_data_provider));
-                    }
-                    // Spend the remaining input value, if any
-                    auto& wallet{fuzzed_data_provider.ConsumeBool() ? a : b};
-                    tx.vout.emplace_back(in, wallet.GetScriptPubKey(fuzzed_data_provider));
-                    // Add tx to block
-                    block.vtx.emplace_back(MakeTransactionRef(tx));
-                    // Check that funding the tx doesn't crash the wallet
-                    a.FundTx(fuzzed_data_provider, tx);
-                    b.FundTx(fuzzed_data_provider, tx);
-                }
-                // Mine block
-                const uint256& hash = block.GetHash();
-                interfaces::BlockInfo info{hash};
-                info.prev_hash = &block.hashPrevBlock;
-                info.height = chain.size();
-                info.data = &block;
-                // Ensure that no blocks are skipped by the wallet by setting the chain's accumulated
-                // time to the maximum value. This ensures that the wallet's birth time is always
-                // earlier than this maximum time.
-                info.chain_time_max = std::numeric_limits<unsigned int>::max();
-                a.wallet->blockConnected(ChainstateRole::NORMAL, info);
-                b.wallet->blockConnected(ChainstateRole::NORMAL, info);
-                // Store the coins for the next block
-                Coins coins_new;
-                for (const auto& tx : block.vtx) {
-                    uint32_t i{0};
-                    for (const auto& out : tx->vout) {
-                        coins_new.emplace(out.nValue, COutPoint{tx->GetHash(), i++});
-                    }
-                }
-                chain.emplace_back(coins_new, CBlock{});
-            },
-            [&] {
-                if (chain.size() <= 1) return; // The first entry can't be removed
-                auto& [coins, block]{chain.back()};
-                if (block.vtx.empty()) return; // Can only disconnect if the block was submitted first
-                // Disconnect block
-                const uint256& hash = block.GetHash();
-                interfaces::BlockInfo info{hash};
-                info.prev_hash = &block.hashPrevBlock;
-                info.height = chain.size() - 1;
-                info.data = &block;
-                a.wallet->blockDisconnected(info);
-                b.wallet->blockDisconnected(info);
-                chain.pop_back();
-            });
-        auto& [coins, first_block]{chain.front()};
-        if (!first_block.vtx.empty()) {
-            // Only check balance when at least one block was submitted
-            const auto bal_a{GetBalance(*a.wallet).m_mine_trusted};
-            const auto bal_b{GetBalance(*b.wallet).m_mine_trusted};
-            assert(total_amount == bal_a + bal_b);
-        }
-    }
-}
-} // namespace
-} // namespace wallet