From fea75ad3caa29972db32d3ce7e0fe125ec77a0eb Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Mon, 8 Aug 2022 11:44:27 +0100 Subject: [PATCH] refactor: Drop `boost/algorithm/string/replace.hpp` dependency --- src/util/string.cpp | 9 +++++---- src/util/string.h | 2 +- test/lint/lint-includes.py | 3 +-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/string.cpp b/src/util/string.cpp index dff782c3309..db6dbe4135b 100644 --- a/src/util/string.cpp +++ b/src/util/string.cpp @@ -4,11 +4,12 @@ #include -#include - +#include #include +#include -void ReplaceAll(std::string& in_out, std::string_view search, std::string_view substitute) +void ReplaceAll(std::string& in_out, const std::string& search, const std::string& substitute) { - boost::replace_all(in_out, search, substitute); + if (search.empty()) return; + in_out = std::regex_replace(in_out, std::regex(std::move(search)), substitute); } diff --git a/src/util/string.h b/src/util/string.h index df20e34ae9a..dd4de888bbe 100644 --- a/src/util/string.h +++ b/src/util/string.h @@ -17,7 +17,7 @@ #include #include -void ReplaceAll(std::string& in_out, std::string_view search, std::string_view substitute); +void ReplaceAll(std::string& in_out, const std::string& search, const std::string& substitute); [[nodiscard]] inline std::vector SplitString(std::string_view str, char sep) { diff --git a/test/lint/lint-includes.py b/test/lint/lint-includes.py index afdca0d418d..b3fa4b93034 100755 --- a/test/lint/lint-includes.py +++ b/test/lint/lint-includes.py @@ -21,8 +21,7 @@ EXCLUDED_DIRS = ["src/leveldb/", "src/minisketch/", ] -EXPECTED_BOOST_INCLUDES = ["boost/algorithm/string/replace.hpp", - "boost/date_time/posix_time/posix_time.hpp", +EXPECTED_BOOST_INCLUDES = ["boost/date_time/posix_time/posix_time.hpp", "boost/multi_index/hashed_index.hpp", "boost/multi_index/ordered_index.hpp", "boost/multi_index/sequenced_index.hpp",