diff --git a/src/Makefile.am b/src/Makefile.am index 99b2184cf25..27f947d7a50 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -230,6 +230,7 @@ BITCOIN_CORE_H = \ node/mini_miner.h \ node/minisketchwrapper.h \ node/peerman_args.h \ + node/protocol_version.h \ node/psbt.h \ node/transaction.h \ node/txreconciliation.h \ @@ -658,8 +659,7 @@ libbitcoin_consensus_a_SOURCES = \ uint256.cpp \ uint256.h \ util/strencodings.cpp \ - util/strencodings.h \ - version.h + util/strencodings.h # # common # diff --git a/src/bench/rpc_blockchain.cpp b/src/bench/rpc_blockchain.cpp index 0fb222f3b5d..2416d40798b 100644 --- a/src/bench/rpc_blockchain.cpp +++ b/src/bench/rpc_blockchain.cpp @@ -23,7 +23,7 @@ struct TestBlockAndIndex { TestBlockAndIndex() { - CDataStream stream(benchmark::data::block413567, SER_NETWORK, PROTOCOL_VERSION); + DataStream stream{benchmark::data::block413567}; std::byte a{0}; stream.write({&a, 1}); // Prevent compaction diff --git a/src/external_signer.cpp b/src/external_signer.cpp index 8cf57cde92c..749bb5f74fd 100644 --- a/src/external_signer.cpp +++ b/src/external_signer.cpp @@ -9,7 +9,6 @@ #include #include #include -#include #include #include diff --git a/src/net.h b/src/net.h index 4347bf12ca1..28f304b0621 100644 --- a/src/net.h +++ b/src/net.h @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -30,7 +31,6 @@ #include #include #include -#include #include #include diff --git a/src/version.h b/src/node/protocol_version.h similarity index 86% rename from src/version.h rename to src/node/protocol_version.h index c2ebeecbfb8..43c1bf6c5bc 100644 --- a/src/version.h +++ b/src/node/protocol_version.h @@ -1,9 +1,9 @@ -// Copyright (c) 2012-2020 The Bitcoin Core developers +// Copyright (c) 2012-present The Bitcoin Core developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_VERSION_H -#define BITCOIN_VERSION_H +#ifndef BITCOIN_NODE_PROTOCOL_VERSION_H +#define BITCOIN_NODE_PROTOCOL_VERSION_H /** * network protocol versioning @@ -35,4 +35,4 @@ static const int INVALID_CB_NO_BAN_VERSION = 70015; //! "wtxidrelay" command for wtxid-based relay starts with this version static const int WTXID_RELAY_VERSION = 70016; -#endif // BITCOIN_VERSION_H +#endif // BITCOIN_NODE_PROTOCOL_VERSION_H diff --git a/src/psbt.cpp b/src/psbt.cpp index e46032f5d50..b2ee3ce7a5e 100644 --- a/src/psbt.cpp +++ b/src/psbt.cpp @@ -8,7 +8,6 @@ #include