mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-08 19:53:27 +01:00

Files

Jonas Schnelli a587f85853 Merge #18587 : gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged

d3a56be77a Revert "gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged" (Russell Yanofsky)
bf0a510981 gui: Avoid wallet tryGetBalances calls before TransactionChanged or BlockTip notifications (Russell Yanofsky)
2bc9b92ed8 Cancel wallet balance timer when shutdown requested (Russell Yanofsky)
83f69fab3a Switch transaction table to use wallet height not node height (Russell Yanofsky)

Pull request description:

  Main commit `gui: Avoid wallet tryGetBalances calls` is one-line change to `WalletModel::pollBalanceChanged` that returns early if there hasn't been a new `TransactionChanged` or `BlockTip` notification since the previous poll call. This is the same behavior that was implemented in #18160, now implemented in a simpler way.

  The other commits are a straight revert of #18160, and two tweaks to avoid relying on `WalletModel::m_client_model` lifetime which were causing travis failures with earlier versions of this PR.

  Motivation for this change is to be able to revert #18160 and cut down on unnecessary cross-process calls that happen when #18160 is combined with #10102

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  jonasschnelli:
    utACK d3a56be77a

Tree-SHA512: 3cd31ca515e77c3bd7160d3f1ea0dce5050d4038b2aa441b6f66b8599bd413d81ca5542a197806e773d6092dd1d26830932b1cecbc95298b1f1ab41099e2f12f

2020-05-20 11:09:29 +02:00

chain.cpp

Merge #18922 : gui: Do not translate InitWarning messages in debug.log

2020-05-13 20:30:39 +02:00

chain.h

gui: Do not translate InitWarning messages in debug.log

2020-05-10 18:01:28 +03:00

handler.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

handler.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

node.cpp

refactor: Pass SynchronizationState enum to GUI

2020-05-19 02:49:32 +03:00

node.h

refactor: Pass SynchronizationState enum to GUI

2020-05-19 02:49:32 +03:00

README.md

…

wallet.cpp

Merge #18587 : gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged

2020-05-20 11:09:29 +02:00

wallet.h

Merge #18587 : gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged

2020-05-20 11:09:29 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.