mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-06 18:53:21 +01:00

Files

fanquake 638855af63 Merge bitcoin/bitcoin#19101 : refactor: remove ::vpwallets and related global variables

62a09a3077 refactor: remove ::vpwallets and related global variables (Russell Yanofsky)

Pull request description:

  Get rid of global wallet list variables by moving them to WalletContext struct

  - [`cs_wallets`](e638acf697/src/wallet/wallet.cpp (L56)) is now [`WalletContext::wallet_mutex`](4be544c7ec/src/wallet/context.h (L37))
  - [`vpwallets`](e638acf697/src/wallet/wallet.cpp (L57)) is now [`WalletContext::wallets`](4be544c7ec/src/wallet/context.h (L38))
  - [`g_load_wallet_fns`](e638acf697/src/wallet/wallet.cpp (L58)) is now [`WalletContext::wallet_load_fns`](4be544c7ec/src/wallet/context.h (L39))

ACKs for top commit:
  achow101:
    ACK 62a09a3077
  meshcollider:
    re-utACK 62a09a3077

Tree-SHA512: 74428180d57b4214c3d96963e6ff43e8778f6f23b6880262d1272f2de67d02714fdc3ebb558f62e48655b221a642c36f80ef37c8f89d362e2d66fd93cbf03b8f

2021-08-19 09:42:21 +08:00

chain.h

Merge bitcoin/bitcoin#22215 : refactor: Add FoundBlock.found member

2021-08-18 08:49:48 +08:00

echo.cpp

…

echo.h

…

handler.cpp

…

handler.h

…

init.cpp

…

init.h

…

ipc.h

Add ipc::Context and ipc::capnp::Context structs

2021-06-10 09:58:45 -05:00

node.h

refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage

2021-06-16 10:48:58 +02:00

README.md

…

wallet.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.