highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-09 20:23:35 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
f86a3014338de6a2204bbdda10795b75ef6654c0
bitcoin/src/wallet
History
Andrew Chow 7952a5934a Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization 
fa38d86235 Use only Span{} constructor for byte-like types where possible (MarcoFalke)
fa257bc831 util: Allow std::byte and char Span serialization (MarcoFalke)

Pull request description:

  Seems odd to require developers to cast all byte-like spans passed to serialization to `unsigned char`-spans. Fix that by passing and accepting byte-like spans as-is. Finally, add tests and update the code to use just `Span` where possible.

ACKs for top commit:
  sipa:
    utACK fa38d86235
  achow101:
    ACK fa38d86235
  ryanofsky:
    Code review ACK fa38d86235. This looks great. The second commit really removes a lot of boilerplate and shows why the first commit is useful.

Tree-SHA512: 788592d9ff515c3ebe73d48f9ecbb8d239f5b985af86f09974e508cafb0ca6d73a959350295246b4dfb496149bc56330a0b5d659fc434ba6723dbaba0b7a49e5
2023-06-28 15:12:12 -04:00
..
rpc
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
test
Use only Span{} constructor for byte-like types where possible
2023-06-27 10:13:37 +02:00
bdb.cpp
wallet: Add GetPrefixCursor to DatabaseBatch
2023-06-01 13:09:08 -04:00
bdb.h
wallet: Add GetPrefixCursor to DatabaseBatch
2023-06-01 13:09:08 -04:00
coincontrol.cpp
…
coincontrol.h
…
coinselection.cpp
[bug] Increase SRD target by change_fee
2023-06-21 16:19:19 -04:00
coinselection.h
[bug] Increase SRD target by change_fee
2023-06-21 16:19:19 -04:00
context.cpp
…
context.h
…
crypter.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
crypter.h
…
db.cpp
…
db.h
wallet: Add GetPrefixCursor to DatabaseBatch
2023-06-01 13:09:08 -04:00
dump.cpp
Use only Span{} constructor for byte-like types where possible
2023-06-27 10:13:37 +02:00
dump.h
…
external_signer_scriptpubkeyman.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
external_signer_scriptpubkeyman.h
…
feebumper.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
feebumper.h
…
fees.cpp
…
fees.h
…
init.cpp
…
interfaces.cpp
…
load.cpp
scripted-diff: move settings to common namespace
2023-05-30 17:26:51 +02:00
load.h
…
receive.cpp
…
receive.h
…
salvage.cpp
salvage: Remove use of ReadKeyValue in salvage
2023-06-19 16:46:39 -04:00
salvage.h
…
scriptpubkeyman.cpp
Merge bitcoin/bitcoin#25634: wallet, tests: Expand and test when the blank wallet flag should be un/set
2023-06-14 09:30:39 -04:00
scriptpubkeyman.h
Merge bitcoin/bitcoin#27759: Fix #includes in src/wallet
2023-05-29 16:33:14 +01:00
spend.cpp
[bug] Increase SRD target by change_fee
2023-06-21 16:19:19 -04:00
spend.h
…
sqlite.cpp
Merge bitcoin/bitcoin#27801: wallet: Add tracing for sqlite statements
2023-06-05 10:51:08 +01:00
sqlite.h
wallet: Add GetPrefixCursor to DatabaseBatch
2023-06-01 13:09:08 -04:00
transaction.cpp
…
transaction.h
…
types.h
…
wallet.cpp
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
wallet.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
walletdb.cpp
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
walletdb.h
walletdb: Refactor legacy wallet record loading into its own function
2023-06-27 11:00:47 -04:00
wallettool.cpp
…
wallettool.h
…
walletutil.cpp
…
walletutil.h
Merge bitcoin/bitcoin#25634: wallet, tests: Expand and test when the blank wallet flag should be un/set
2023-06-14 09:30:39 -04:00