diff --git a/.github/workflows/pr-python-connector-tests.yml b/.github/workflows/pr-python-connector-tests.yml index f7f3972b3..aa740aa8d 100644 --- a/.github/workflows/pr-python-connector-tests.yml +++ b/.github/workflows/pr-python-connector-tests.yml @@ -50,6 +50,9 @@ env: GITBOOK_API_KEY: ${{ secrets.GITBOOK_API_KEY }} # Notion NOTION_INTEGRATION_TOKEN: ${{ secrets.NOTION_INTEGRATION_TOKEN }} + # Highspot + HIGHSPOT_KEY: ${{ secrets.HIGHSPOT_KEY }} + HIGHSPOT_SECRET: ${{ secrets.HIGHSPOT_SECRET }} jobs: connectors-check: diff --git a/backend/onyx/connectors/highspot/connector.py b/backend/onyx/connectors/highspot/connector.py index b2ff2aa2c..380d878a5 100644 --- a/backend/onyx/connectors/highspot/connector.py +++ b/backend/onyx/connectors/highspot/connector.py @@ -18,8 +18,8 @@ from onyx.connectors.interfaces import SecondsSinceUnixEpoch from onyx.connectors.interfaces import SlimConnector from onyx.connectors.models import ConnectorMissingCredentialError from onyx.connectors.models import Document -from onyx.connectors.models import Section from onyx.connectors.models import SlimDocument +from onyx.connectors.models import TextSection from onyx.file_processing.extract_file_text import extract_file_text from onyx.file_processing.extract_file_text import VALID_FILE_EXTENSIONS from onyx.indexing.indexing_heartbeat import IndexingHeartbeatInterface @@ -222,7 +222,7 @@ class HighspotConnector(LoadConnector, PollConnector, SlimConnector): Document( id=f"HIGHSPOT_{item_id}", sections=[ - Section( + TextSection( link=item_details.get( "url", f"https://www.highspot.com/items/{item_id}", diff --git a/backend/tests/daily/connectors/highspot/test_highspot_connector.py b/backend/tests/daily/connectors/highspot/test_highspot_connector.py index a9ceebc9e..6da06b58c 100644 --- a/backend/tests/daily/connectors/highspot/test_highspot_connector.py +++ b/backend/tests/daily/connectors/highspot/test_highspot_connector.py @@ -69,6 +69,7 @@ def test_highspot_connector_basic(highspot_connector: HighspotConnector) -> None section = target_test_doc.sections[0] assert section.link is not None # Only check if content exists, as exact content might change + assert section.text is not None assert len(section.text) > 0