From b2ce848b53d966eecd2b99c4ccb9cc9419ff5886 Mon Sep 17 00:00:00 2001
From: pablodanswer <pablo@danswer.ai>
Date: Sun, 26 Jan 2025 13:51:17 -0800
Subject: [PATCH] add fix

---
 .../internet_search/internet_search_tool.py   |  9 ++++++-
 .../app/admin/assistants/AssistantEditor.tsx  | 27 ++++---------------
 2 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/backend/onyx/tools/tool_implementations/internet_search/internet_search_tool.py b/backend/onyx/tools/tool_implementations/internet_search/internet_search_tool.py
index feb49318a6a5..38e1249372a1 100644
--- a/backend/onyx/tools/tool_implementations/internet_search/internet_search_tool.py
+++ b/backend/onyx/tools/tool_implementations/internet_search/internet_search_tool.py
@@ -220,6 +220,13 @@ class InternetSearchTool(Tool):
         )
         results = response.json()
 
+        # If no hits, Bing does not include the webPages key
+        search_results = (
+            results["webPages"]["value"][: self.num_results]
+            if "webPages" in results
+            else []
+        )
+
         return InternetSearchResponse(
             revised_query=query,
             internet_results=[
@@ -228,7 +235,7 @@ class InternetSearchTool(Tool):
                     link=result["url"],
                     snippet=result["snippet"],
                 )
-                for result in results["webPages"]["value"][: self.num_results]
+                for result in search_results
             ],
         )
 
diff --git a/web/src/app/admin/assistants/AssistantEditor.tsx b/web/src/app/admin/assistants/AssistantEditor.tsx
index 6692dbb5ee07..8eafdd24dcd8 100644
--- a/web/src/app/admin/assistants/AssistantEditor.tsx
+++ b/web/src/app/admin/assistants/AssistantEditor.tsx
@@ -910,28 +910,11 @@ export function AssistantEditor({
 
                     {internetSearchTool && (
                       <>
-                        <div className="flex items-center content-start mb-2">
-                          <Checkbox
-                            size="sm"
-                            id={`enabled_tools_map.${internetSearchTool.id}`}
-                            checked={
-                              values.enabled_tools_map[internetSearchTool.id]
-                            }
-                            onCheckedChange={() => {
-                              toggleToolInValues(internetSearchTool.id);
-                            }}
-                            name={`enabled_tools_map.${internetSearchTool.id}`}
-                          />
-                          <div className="flex flex-col ml-2">
-                            <span className="text-sm">
-                              {internetSearchTool.display_name}
-                            </span>
-                            <span className="text-xs text-subtle">
-                              Access real-time information and search the web
-                              for up-to-date results
-                            </span>
-                          </div>
-                        </div>
+                        <BooleanFormField
+                          name={`enabled_tools_map.${internetSearchTool.id}`}
+                          label={internetSearchTool.display_name}
+                          subtext="Access real-time information and search the web for up-to-date results"
+                        />
                       </>
                     )}