From 0a35422d1da40faa63fd64a1ebf1b105a9ed70bf Mon Sep 17 00:00:00 2001 From: "Richard Kuo (Danswer)" Date: Wed, 4 Dec 2024 16:47:42 -0800 Subject: [PATCH 1/4] wait for the page to load --- web/tests/e2e/home.spec.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/web/tests/e2e/home.spec.ts b/web/tests/e2e/home.spec.ts index 2b1605fa1d00..ff6105ce6a52 100644 --- a/web/tests/e2e/home.spec.ts +++ b/web/tests/e2e/home.spec.ts @@ -27,5 +27,11 @@ test( await page.click('button[type="submit"]'); await page.waitForURL("http://localhost:3000/chat"); + + // Create the locator (no waiting happens here) + const textarea = page.locator('textarea[placeholder="Send a message "]'); + + // Explicitly wait for the textarea to be visible + await expect(textarea).toBeVisible(); } ); From 4b6a4c6bbf0d3fde014a588432eaabd29496f909 Mon Sep 17 00:00:00 2001 From: "Richard Kuo (Danswer)" Date: Wed, 4 Dec 2024 17:19:16 -0800 Subject: [PATCH 2/4] fix up tests --- web/tests/e2e/admin_assistants.spec.ts | 3 +++ web/tests/e2e/home.spec.ts | 6 +----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/web/tests/e2e/admin_assistants.spec.ts b/web/tests/e2e/admin_assistants.spec.ts index 308d0975e36c..a5ccf92c71f3 100644 --- a/web/tests/e2e/admin_assistants.spec.ts +++ b/web/tests/e2e/admin_assistants.spec.ts @@ -12,5 +12,8 @@ test( await expect(page.locator("p.text-sm").nth(0)).toHaveText( /^Assistants are a way to build/ ); + + const generalTextLocator = page.locator("tr.border-b td").nth(1); + await expect(generalTextLocator.locator("p.text")).toHaveText("General"); } ); diff --git a/web/tests/e2e/home.spec.ts b/web/tests/e2e/home.spec.ts index ff6105ce6a52..05f8526b31b3 100644 --- a/web/tests/e2e/home.spec.ts +++ b/web/tests/e2e/home.spec.ts @@ -28,10 +28,6 @@ test( await page.waitForURL("http://localhost:3000/chat"); - // Create the locator (no waiting happens here) - const textarea = page.locator('textarea[placeholder="Send a message "]'); - - // Explicitly wait for the textarea to be visible - await expect(textarea).toBeVisible(); + await page.getByPlaceholder("Send a message "); } ); From 4dbc6bb4d1c57099621f2e07f311c9e91df1c34a Mon Sep 17 00:00:00 2001 From: "Richard Kuo (Danswer)" Date: Wed, 4 Dec 2024 17:49:59 -0800 Subject: [PATCH 3/4] make sure "Initializing Danswer" is gone --- web/tests/e2e/home.spec.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/tests/e2e/home.spec.ts b/web/tests/e2e/home.spec.ts index 05f8526b31b3..74a9bba9653b 100644 --- a/web/tests/e2e/home.spec.ts +++ b/web/tests/e2e/home.spec.ts @@ -29,5 +29,9 @@ test( await page.waitForURL("http://localhost:3000/chat"); await page.getByPlaceholder("Send a message "); + + await expect(page.locator("body")).not.toContainText( + "Initializing Danswer" + ); } ); From b9eb1ca2ba9da84523fdcb2dc7ad5187c86c6291 Mon Sep 17 00:00:00 2001 From: "Richard Kuo (Danswer)" Date: Wed, 4 Dec 2024 18:23:06 -0800 Subject: [PATCH 4/4] wait for whole placeholder string --- web/tests/e2e/home.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/tests/e2e/home.spec.ts b/web/tests/e2e/home.spec.ts index 74a9bba9653b..a9b882443925 100644 --- a/web/tests/e2e/home.spec.ts +++ b/web/tests/e2e/home.spec.ts @@ -28,7 +28,7 @@ test( await page.waitForURL("http://localhost:3000/chat"); - await page.getByPlaceholder("Send a message "); + await page.getByPlaceholder("Send a message or try using @ or /"); await expect(page.locator("body")).not.toContainText( "Initializing Danswer"