From fe8a5d671a04b3340e8cbd1787f4db5c6f551d13 Mon Sep 17 00:00:00 2001 From: rkuo-danswer Date: Fri, 21 Feb 2025 13:40:07 -0800 Subject: [PATCH] don't spam the logs with texts on auth errors (#4085) * don't spam the logs with texts on auth errors * refactor the logging a bit --------- Co-authored-by: Richard Kuo (Danswer) --- backend/model_server/encoders.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/backend/model_server/encoders.py b/backend/model_server/encoders.py index 52e1ddf8b..8521cd001 100644 --- a/backend/model_server/encoders.py +++ b/backend/model_server/encoders.py @@ -98,12 +98,17 @@ class CloudEmbedding: return final_embeddings except Exception as e: error_string = ( - f"Error embedding text with OpenAI: {str(e)} \n" - f"Model: {model} \n" - f"Provider: {self.provider} \n" - f"Texts: {texts}" + f"Exception embedding text with OpenAI - {type(e)}: " + f"Model: {model} " + f"Provider: {self.provider} " + f"Exception: {e}" ) logger.error(error_string) + + # only log text when it's not an authentication error. + if not isinstance(e, openai.AuthenticationError): + logger.debug(f"Exception texts: {texts}") + raise RuntimeError(error_string) async def _embed_cohere(