From 146e353d9c3dec7a7db26c17245f6886d7d1dcce Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Tue, 26 Jan 2021 17:41:28 +0100 Subject: [PATCH] avformat/flvdec: Check for avio_read() failure in amf_get_string() Suggested-by: Anton Khirnov Signed-off-by: Michael Niedermayer (cherry picked from commit cb316676112c01e8d66420908b6b3d06b3b498e3) Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 6e07b59676..d3ff893edb 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -384,13 +384,18 @@ static int flv_set_video_codec(AVFormatContext *s, AVStream *vstream, static int amf_get_string(AVIOContext *ioc, char *buffer, int buffsize) { + int ret; int length = avio_rb16(ioc); if (length >= buffsize) { avio_skip(ioc, length); return -1; } - avio_read(ioc, buffer, length); + ret = avio_read(ioc, buffer, length); + if (ret < 0) + return ret; + if (ret < length) + return AVERROR_INVALIDDATA; buffer[length] = '\0';