From 15ccdea8b381e4e120fd5a98b98b6fde5371097f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 9 Feb 2020 19:40:34 +0100 Subject: [PATCH] avfilter/vf_dedot: Fix leak of AVFrame if making it writable fails Even in this scenario, the frame still contains references to data that won't be freed if the frame isn't unreferenced. And the AVFrame itself will leak, too. Fixes Coverity issue #1441422. Signed-off-by: Andreas Rheinhardt Reviewed-by: Paul B Mahol Signed-off-by: Michael Niedermayer (cherry picked from commit 212077eda46c4c3eb644774d2b1ccbeb3e322fff) --- libavfilter/vf_dedot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_dedot.c b/libavfilter/vf_dedot.c index bb0f9e5ac8..ff2e0e3a79 100644 --- a/libavfilter/vf_dedot.c +++ b/libavfilter/vf_dedot.c @@ -312,7 +312,8 @@ static int activate(AVFilterContext *ctx) FFMIN(s->planeheight[2], ff_filter_get_nb_threads(ctx))); } - } + } else + av_frame_free(&out); } else if (!out) { ret = AVERROR(ENOMEM); }