From 31327c2d075a413749c1461c06382993b9bba90e Mon Sep 17 00:00:00 2001 From: James Almer Date: Sat, 27 Apr 2024 19:38:13 -0300 Subject: [PATCH] avformat/mov: fix the check for the heif item parsing loop Fixes: Null pointer dereference Fixes: 67861/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5352628142800896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: James Almer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ecd29a7d08..ede25d3342 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -9440,7 +9440,8 @@ static int mov_parse_tiles(AVFormatContext *s) break; } - if (k == grid->nb_tiles) { + if (k == mov->nb_heif_item) { + av_assert0(loop); av_log(s, AV_LOG_WARNING, "HEIF item id %d referenced by grid id %d doesn't " "exist\n", tile_id, grid->item->item_id);