From 321294adb788b5e143fcec776cdf1daf79ed921c Mon Sep 17 00:00:00 2001 From: Mark Thompson Date: Mon, 24 Sep 2018 22:45:50 +0100 Subject: [PATCH] h264_metadata: Avoid integer overflow in bitrate Fixes CID #1439664. --- libavcodec/h264_metadata_bsf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 991fcfa537..bf37528234 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264_metadata_bsf.c @@ -226,10 +226,10 @@ static int h264_metadata_update_sps(AVBSFContext *bsf, if (sps->vui.nal_hrd_parameters_present_flag) { bit_rate = (sps->vui.nal_hrd_parameters.bit_rate_value_minus1[0] + 1) * - (1 << (sps->vui.nal_hrd_parameters.bit_rate_scale + 6)); + (INT64_C(1) << (sps->vui.nal_hrd_parameters.bit_rate_scale + 6)); } else if (sps->vui.vcl_hrd_parameters_present_flag) { bit_rate = (sps->vui.vcl_hrd_parameters.bit_rate_value_minus1[0] + 1) * - (1 << (sps->vui.vcl_hrd_parameters.bit_rate_scale + 6)); + (INT64_C(1) << (sps->vui.vcl_hrd_parameters.bit_rate_scale + 6)); // Adjust for VCL vs. NAL limits. bit_rate = bit_rate * 6 / 5; } else {