From 7c0748c2db015cf2bf2c4a32a43bd1d2697afc1e Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 23 Mar 2012 00:27:59 +0100 Subject: [PATCH] eatqi: replace break by goto. This fixes some heap overread. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer --- libavcodec/eatqi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/eatqi.c b/libavcodec/eatqi.c index 5b7ff39e4a..337fa8ea1b 100644 --- a/libavcodec/eatqi.c +++ b/libavcodec/eatqi.c @@ -139,9 +139,10 @@ static int tqi_decode_frame(AVCodecContext *avctx, for (s->mb_x=0; s->mb_x<(avctx->width+15)/16; s->mb_x++) { if(tqi_decode_mb(s, t->block) < 0) - break; + goto end; tqi_idct_put(t, t->block); } + end: *data_size = sizeof(AVFrame); *(AVFrame*)data = t->frame;