From a0faf0db4f9f85ce2b8e00660c4fd884a347ca19 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 21 Feb 2020 12:53:30 -0800 Subject: [PATCH] avformat/utils: Don't trigger errors for multiple id3 tags. Such errors may make sense for specific formats, but general parsing logic shouldn't be treating these as errors regardless of the error recognition mode. Fixes loading of the following wave when using -err_detect explode: https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/webaudio/resources/4ch-440.wav Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 123d67800b..cb15f6a4b3 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -635,15 +635,8 @@ FF_ENABLE_DEPRECATION_WARNINGS s->metadata = s->internal->id3v2_meta; s->internal->id3v2_meta = NULL; } else if (s->internal->id3v2_meta) { - int level = AV_LOG_WARNING; - if (s->error_recognition & AV_EF_COMPLIANT) - level = AV_LOG_ERROR; - av_log(s, level, "Discarding ID3 tags because more suitable tags were found.\n"); + av_log(s, AV_LOG_WARNING, "Discarding ID3 tags because more suitable tags were found.\n"); av_dict_free(&s->internal->id3v2_meta); - if (s->error_recognition & AV_EF_EXPLODE) { - ret = AVERROR_INVALIDDATA; - goto close; - } } if (id3v2_extra_meta) {