From b5300c8ad8c5384ab3654d6cb27693422bc424e7 Mon Sep 17 00:00:00 2001 From: "Ronald S. Bultje" Date: Wed, 29 Mar 2017 09:03:49 -0400 Subject: [PATCH] h264: don't write to source picture object in ff_h264_ref_picture(). Doing so is analogous to writing to source data in memcpy(), and causes (harmless) tsan warnings in fate-h264. --- libavcodec/h264_picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index f634d2a1a7..db9673793a 100644 --- a/libavcodec/h264_picture.c +++ b/libavcodec/h264_picture.c @@ -70,8 +70,8 @@ int ff_h264_ref_picture(H264Context *h, H264Picture *dst, H264Picture *src) av_assert0(!dst->f->buf[0]); av_assert0(src->f->buf[0]); + av_assert0(src->tf.f == src->f); - src->tf.f = src->f; dst->tf.f = dst->f; ret = ff_thread_ref_frame(&dst->tf, &src->tf); if (ret < 0)