From b9a667c00d0fa4a5bd7a0d1f00f393482b98c729 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 27 Jan 2020 09:28:19 +0100 Subject: [PATCH] avformat/mov: Don't leak MOVFragmentStreamInfo on error Fixes Coverity issue #1441933. Signed-off-by: Andreas Rheinhardt Signed-off-by: Michael Niedermayer (cherry picked from commit 43f58f2354bfab3819e44c1a97b0af75cc091226) Signed-off-by: Andreas Rheinhardt --- libavformat/mov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 358369b74b..6d41823553 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1330,8 +1330,10 @@ static int update_frag_index(MOVContext *c, int64_t offset) for (i = 0; i < c->fc->nb_streams; i++) { // Avoid building frag index if streams lack track id. - if (c->fc->streams[i]->id < 0) + if (c->fc->streams[i]->id < 0) { + av_free(frag_stream_info); return AVERROR_INVALIDDATA; + } frag_stream_info[i].id = c->fc->streams[i]->id; frag_stream_info[i].sidx_pts = AV_NOPTS_VALUE;