From cffadfe99a1c41866701bab6c7410c17737a1db1 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Tue, 20 Feb 2024 18:47:46 +0100 Subject: [PATCH] avformat/movenc: Make check actually check what is intended Also fixes a Clang warning: "overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]" Reviewed-by: James Almer Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index afcee683cd..724a1eb673 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -7160,7 +7160,7 @@ static int mov_init_iamf_track(AVFormatContext *s) if (!nb_audio_elements && !nb_mix_presentations) return 0; - if ((nb_audio_elements < 1 && nb_audio_elements > 2) || nb_mix_presentations < 1) { + if (nb_audio_elements < 1 || nb_audio_elements > 2 || nb_mix_presentations < 1) { av_log(s, AV_LOG_ERROR, "There must be >= 1 and <= 2 IAMF_AUDIO_ELEMENT and at least " "one IAMF_MIX_PRESENTATION stream groups to write a IMAF track\n"); return AVERROR(EINVAL);