From e1669c5ebe775c81d4b5e6abf8d03a9e86d1c5a8 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Mon, 13 Aug 2007 22:15:48 +0000 Subject: [PATCH] Attempt to better explain how to split patches into individual self-contained pieces. Originally committed as revision 10108 to svn://svn.ffmpeg.org/ffmpeg/trunk --- doc/ffmpeg-doc.texi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg-doc.texi b/doc/ffmpeg-doc.texi index 53f36a1a0d..fafe3cb4cf 100644 --- a/doc/ffmpeg-doc.texi +++ b/doc/ffmpeg-doc.texi @@ -1673,9 +1673,12 @@ First, (@pxref{Coding Rules}) above if you did not yet. When you submit your patch, try to send a unified diff (diff '-up' option). We cannot read other diffs :-) -Also please do not submit patches which contain several unrelated changes. -Split them into individual self-contained patches; this makes reviewing -them much easier. +Also please do not submit a patch which contains several unrelated changes. +Split it into separate, self-contained pieces. This does not mean splitting +file by file. Instead, make the patch as small as possible while still +keeping it as a logical unit that contains an individual change, even +if it spans multiple files. This makes reviewing your patches much easier +for us and greatly increases your chances of getting your patch applied. Run the regression tests before submitting a patch so that you can verify that there are no big problems.