From f1eb6ddcb34f4d27d52d4a0a30269728612c41b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Heusipp?= Date: Sun, 17 Jul 2016 15:37:12 +0200 Subject: [PATCH] libavformat/libopenmpt: Fix memory leak in error path in read_header_openmpt(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Heusipp Signed-off-by: Michael Niedermayer --- libavformat/libopenmpt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index fd388280dc..58a02be610 100644 --- a/libavformat/libopenmpt.c +++ b/libavformat/libopenmpt.c @@ -89,8 +89,11 @@ static int read_header_openmpt(AVFormatContext *s) add_meta(s, "comment", openmpt_module_get_metadata(openmpt->module, "message")); st = avformat_new_stream(s, NULL); - if (!st) + if (!st) { + openmpt_module_destroy(openmpt->module); + openmpt->module = NULL; return AVERROR(ENOMEM); + } avpriv_set_pts_info(st, 64, 1, 1000); if (st->duration > 0) st->duration = llrint(openmpt->duration*AV_TIME_BASE); @@ -146,6 +149,7 @@ static int read_close_openmpt(AVFormatContext *s) { OpenMPTContext *openmpt = s->priv_data; openmpt_module_destroy(openmpt->module); + openmpt->module = NULL; return 0; }