From 4dcadd4d888c231a460142b2aec397e83bdf4a8f Mon Sep 17 00:00:00 2001 From: fiatjaf Date: Thu, 13 Mar 2025 18:57:28 -0300 Subject: [PATCH] update go version so we can use the new benchmarking helper. --- envelopes_benchmark_test.go | 6 +++--- event_test.go | 4 ++-- go.mod | 2 +- nip13/nip13_test.go | 23 ----------------------- 4 files changed, 6 insertions(+), 29 deletions(-) diff --git a/envelopes_benchmark_test.go b/envelopes_benchmark_test.go index 04127b8..06f861f 100644 --- a/envelopes_benchmark_test.go +++ b/envelopes_benchmark_test.go @@ -17,7 +17,7 @@ func BenchmarkParseMessage(b *testing.B) { messages := generateTestMessages(name) b.Run("jsonstdlib", func(b *testing.B) { - for i := 0; i < b.N; i++ { + for b.Loop() { for _, msg := range messages { var v any stdlibjson.Unmarshal(unsafe.Slice(unsafe.StringData(msg), len(msg)), &v) @@ -26,7 +26,7 @@ func BenchmarkParseMessage(b *testing.B) { }) b.Run("easyjson", func(b *testing.B) { - for i := 0; i < b.N; i++ { + for b.Loop() { for _, msg := range messages { _ = ParseMessage(msg) } @@ -35,7 +35,7 @@ func BenchmarkParseMessage(b *testing.B) { b.Run("sonic", func(b *testing.B) { smp := NewSonicMessageParser() - for i := 0; i < b.N; i++ { + for b.Loop() { for _, msg := range messages { _, _ = smp.ParseMessage(msg) } diff --git a/event_test.go b/event_test.go index e5c9c37..a9453a1 100644 --- a/event_test.go +++ b/event_test.go @@ -104,13 +104,13 @@ func BenchmarkIDCheck(b *testing.B) { evt.Sign(GeneratePrivateKey()) b.Run("naïve", func(b *testing.B) { - for i := 0; i < b.N; i++ { + for b.Loop() { _ = evt.GetID() == evt.ID } }) b.Run("big brain", func(b *testing.B) { - for i := 0; i < b.N; i++ { + for b.Loop() { _ = evt.CheckID() } }) diff --git a/go.mod b/go.mod index 1665285..30c3a12 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/nbd-wtf/go-nostr -go 1.23.1 +go 1.24.1 require ( github.com/ImVexed/fasturl v0.0.0-20230304231329-4e41488060f3 diff --git a/nip13/nip13_test.go b/nip13/nip13_test.go index 9cac8be..2b3c2ed 100644 --- a/nip13/nip13_test.go +++ b/nip13/nip13_test.go @@ -129,26 +129,3 @@ func TestDoWorkTimeout(t *testing.T) { } } } - -func BenchmarkDoWork(b *testing.B) { - if testing.Short() { - b.Skip("too consuming for short mode") - } - for _, difficulty := range []int{8, 16, 24} { - difficulty := difficulty - b.Run(fmt.Sprintf("%dbits", difficulty), func(b *testing.B) { - for i := 0; i < b.N; i++ { - event := &nostr.Event{ - Kind: nostr.KindTextNote, - Content: "It's just me mining my own business", - PubKey: "a48380f4cfcc1ad5378294fcac36439770f9c878dd880ffa94bb74ea54a6f243", - } - ctx, cancel := context.WithTimeout(context.Background(), time.Second*60) - defer cancel() - if _, err := DoWork(ctx, *event, difficulty); err != nil { - b.Fatal(err) - } - } - }) - } -}