From f7d00f1dfd858d7e17745322c4cc708377c4316f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20G=C3=B3mez?= Date: Fri, 16 Jan 2026 16:07:07 +0100 Subject: [PATCH] fix: Resolve TypeScript errors in NIP-17 adapter and gift-wrap service - Remove invalid actionOpts parameter from GiftWrapBlueprint.create() Gift wrap blueprints don't accept meta tag options; those belong on the rumor itself which already receives actionOpts correctly. - Fix SubscriptionResponse type handling in gift-wrap.ts Use type guard to safely check for event objects in subscription responses instead of accessing properties that may not exist. Fixes TypeScript compilation errors preventing production builds. Co-Authored-By: Claude Sonnet 4.5 --- src/lib/chat/adapters/nip-17-adapter.ts | 1 - src/services/gift-wrap.ts | 10 ++++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/lib/chat/adapters/nip-17-adapter.ts b/src/lib/chat/adapters/nip-17-adapter.ts index 5dacf1f..decf698 100644 --- a/src/lib/chat/adapters/nip-17-adapter.ts +++ b/src/lib/chat/adapters/nip-17-adapter.ts @@ -702,7 +702,6 @@ export class Nip17Adapter extends ChatProtocolAdapter { GiftWrapBlueprint, activePubkey, rumor, - actionOpts, ); console.log( diff --git a/src/services/gift-wrap.ts b/src/services/gift-wrap.ts index 21c605c..82277f1 100644 --- a/src/services/gift-wrap.ts +++ b/src/services/gift-wrap.ts @@ -440,13 +440,11 @@ class GiftWrapService { .subscription(relays, [reqFilter], { eventStore }) .subscribe({ next: (response) => { - if (response.type === "EVENT") { + // SubscriptionResponse can be NostrEvent or other types + // Events are automatically added to eventStore, just log receipt + if (typeof response === "object" && response && "id" in response) { console.log( - `[GiftWrap] 📨 Received gift wrap ${response.event.id.slice(0, 8)} from relay`, - ); - } else if (response.type === "EOSE") { - console.log( - `[GiftWrap] ✓ EOSE from ${response.relayUrl} (subscription stays open)`, + `[GiftWrap] 📨 Received gift wrap ${response.id.slice(0, 8)} from relay`, ); } },