From 932a9b62a7f10d60fdae3226be7110304304a590 Mon Sep 17 00:00:00 2001 From: alex Date: Sat, 24 Dec 2022 22:53:05 +0100 Subject: [PATCH] start: make http server's listening host/port compatible with IPv6 (#14) previously, a command like this to listen on IPv6 loopback: HOST=::1 PORT=7447 go run ./basic/ would exit immediately because ::1:7447 is an invalid address. IPv6 addresses contain columns, so a simple host + port concatenation doesn't work. net.JoinHostPort is a function to do exactly that. --- start.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/start.go b/start.go index 2f02ed4..574645e 100644 --- a/start.go +++ b/start.go @@ -1,6 +1,7 @@ package relayer import ( + "net" "fmt" "net/http" "os" @@ -72,7 +73,7 @@ func StartConf(s Settings, relay Relay) error { // start http server srv := &http.Server{ Handler: cors.Default().Handler(Router), - Addr: s.Host + ":" + s.Port, + Addr: net.JoinHostPort(s.Host, s.Port), WriteTimeout: 2 * time.Second, ReadTimeout: 2 * time.Second, IdleTimeout: 30 * time.Second,