From f9c9c52d750fa6b029a874806a0faa59ea64d74d Mon Sep 17 00:00:00 2001
From: Pavol Rusnak <pavol@rusnak.io>
Date: Thu, 30 Nov 2023 16:28:17 +0100
Subject: [PATCH] use _blank + noopener + noreferrer consistently

---
 .../admin/_tab_security_notifications.html    |  2 +
 lnbits/core/templates/core/extensions.html    |  1 +
 lnbits/core/templates/core/index.html         | 70 +++++++++++++++----
 lnbits/templates/base.html                    |  4 +-
 4 files changed, 62 insertions(+), 15 deletions(-)

diff --git a/lnbits/core/templates/admin/_tab_security_notifications.html b/lnbits/core/templates/admin/_tab_security_notifications.html
index 03e5bad05..6d250b526 100644
--- a/lnbits/core/templates/admin/_tab_security_notifications.html
+++ b/lnbits/core/templates/admin/_tab_security_notifications.html
@@ -8,6 +8,7 @@
       class="q-btn"
       color="white"
       target="_blank"
+      rel="noopener noreferrer"
       href="https://github.com/lnbits/lnbits/releases"
       v-text="$t('releases')"
     ></a>
@@ -58,6 +59,7 @@
             <a
               v-if="props.row.link"
               target="_blank"
+              rel="noopener noreferrer"
               :href="props.row.link"
               v-text="$t('more')"
             ></a
diff --git a/lnbits/core/templates/core/extensions.html b/lnbits/core/templates/core/extensions.html
index 7e68c2cd7..54618ec08 100644
--- a/lnbits/core/templates/core/extensions.html
+++ b/lnbits/core/templates/core/extensions.html
@@ -394,6 +394,7 @@
                         class="text-secondary float-right"
                         :href="release.html_url"
                         target="_blank"
+                        rel="noopener noreferrer"
                         style="color: inherit"
                         >{%raw%}{{ $t('release_notes') }}{%endraw%}</a
                       >
diff --git a/lnbits/core/templates/core/index.html b/lnbits/core/templates/core/index.html
index 5266d35f9..242164bed 100644
--- a/lnbits/core/templates/core/index.html
+++ b/lnbits/core/templates/core/index.html
@@ -49,7 +49,7 @@
               type="a"
               href="https://github.com/lnbits/lnbits"
               target="_blank"
-              rel="noopener"
+              rel="noopener noreferrer"
               :label="$t('view_github')"
             ></q-btn>
             <q-btn
@@ -58,7 +58,7 @@
               type="a"
               href="https://legend.lnbits.com/paywall/GAqKguK5S8f6w5VNjS9DfK"
               target="_blank"
-              rel="noopener"
+              rel="noopener noreferrer"
               :label="$t('donate')"
             ></q-btn>
           </div>
@@ -82,7 +82,11 @@
         ></q-btn>
         <div class="row">
           <div class="col">
-            <a href="https://github.com/ElementsProject/lightning">
+            <a
+              href="https://github.com/ElementsProject/lightning"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/cln.png') }}' : '{{ static_url_for('static', 'images/clnl.png') }}'"
@@ -90,7 +94,11 @@
             </a>
           </div>
           <div class="col q-pl-md">
-            <a href="https://github.com/lightningnetwork/lnd">
+            <a
+              href="https://github.com/lightningnetwork/lnd"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/lnd.png') }}' : '{{ static_url_for('static', 'images/lnd.png') }}'"
@@ -101,7 +109,11 @@
 
         <div class="row">
           <div class="col">
-            <a href="https://opennode.com">
+            <a
+              href="https://opennode.com"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/opennode.png') }}' : '{{ static_url_for('static', 'images/opennodel.png') }}'"
@@ -109,7 +121,11 @@
             </a>
           </div>
           <div class="col q-pl-md">
-            <a href="https://lnpay.co/">
+            <a
+              href="https://lnpay.co/"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/lnpay.png') }}' : '{{ static_url_for('static', 'images/lnpayl.png') }}'"
@@ -120,7 +136,11 @@
 
         <div class="row">
           <div class="col">
-            <a href="https://github.com/rootzoll/raspiblitz">
+            <a
+              href="https://github.com/rootzoll/raspiblitz"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/blitz.png') }}' : '{{ static_url_for('static', 'images/blitzl.png') }}'"
@@ -128,7 +148,11 @@
             </a>
           </div>
           <div class="col q-pl-md">
-            <a href="https://start9.com/">
+            <a
+              href="https://start9.com/"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/start9.png') }}' : '{{ static_url_for('static', 'images/start9l.png') }}'"
@@ -138,7 +162,11 @@
         </div>
         <div class="row">
           <div class="col">
-            <a href="https://getumbrel.com/">
+            <a
+              href="https://getumbrel.com/"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/umbrel.png') }}' : '{{ static_url_for('static', 'images/umbrell.png') }}'"
@@ -146,7 +174,11 @@
             </a>
           </div>
           <div class="col q-pl-md">
-            <a href="https://mynodebtc.com">
+            <a
+              href="https://mynodebtc.com"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/mynode.png') }}' : '{{ static_url_for('static', 'images/mynodel.png') }}'"
@@ -156,7 +188,11 @@
         </div>
         <div class="row">
           <div class="col">
-            <a href="https://github.com/shesek/spark-wallet">
+            <a
+              href="https://github.com/shesek/spark-wallet"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/spark.png') }}' : '{{ static_url_for('static', 'images/sparkl.png') }}'"
@@ -164,7 +200,11 @@
             </a>
           </div>
           <div class="col q-pl-md">
-            <a href="https://voltage.cloud">
+            <a
+              href="https://voltage.cloud"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/voltage.png') }}' : '{{ static_url_for('static', 'images/voltagel.png') }}'"
@@ -174,7 +214,11 @@
         </div>
         <div class="row">
           <div class="col">
-            <a href="https://getalby.com">
+            <a
+              href="https://getalby.com"
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               <q-img
                 contain
                 :src="($q.dark.isActive) ? '{{ static_url_for('static', 'images/alby.png') }}' : '{{ static_url_for('static', 'images/albyl.png') }}'"
diff --git a/lnbits/templates/base.html b/lnbits/templates/base.html
index 81d73cb12..182a73631 100644
--- a/lnbits/templates/base.html
+++ b/lnbits/templates/base.html
@@ -296,7 +296,7 @@
             type="a"
             href="/docs"
             target="_blank"
-            rel="noopener"
+            rel="noopener noreferrer"
           >
             <span v-text="$t('api_docs')"></span>
             <q-tooltip
@@ -311,7 +311,7 @@
             type="a"
             href="https://github.com/lnbits/lnbits"
             target="_blank"
-            rel="noopener"
+            rel="noopener noreferrer"
           >
             <q-tooltip><span v-text="$t('view_github')"></span></q-tooltip>
           </q-btn>