From 028959f5a0323cb462e13e25d7198dcf91eef7b7 Mon Sep 17 00:00:00 2001
From: undefinedor <wanghao@imwh.net>
Date: Sat, 23 Mar 2024 19:02:23 +0800
Subject: [PATCH] kvdb+watchtower: fix unreachable code

---
 docs/release-notes/release-notes-0.18.0.md | 3 +++
 kvdb/backend.go                            | 2 --
 watchtower/wtclient/session_negotiator.go  | 5 -----
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/docs/release-notes/release-notes-0.18.0.md b/docs/release-notes/release-notes-0.18.0.md
index f73940809..bc72de4c5 100644
--- a/docs/release-notes/release-notes-0.18.0.md
+++ b/docs/release-notes/release-notes-0.18.0.md
@@ -104,6 +104,8 @@
   which with the default fee allocation in place will eventually lead to the
   downsizing to the fee floor (1 sat/vByte) in the worst case.
 
+* [Removed](https://github.com/lightningnetwork/lnd/pull/8577) some unreachable code
+
 # New Features
 ## Functional Enhancements
 
@@ -424,6 +426,7 @@ bitcoin peers' feefilter values into account](https://github.com/lightningnetwor
 * Slyghtning
 * Tee8z
 * Turtle
+* Hao Wang
 * w3irdrobot
 * Yong Yu
 * Ziggie
diff --git a/kvdb/backend.go b/kvdb/backend.go
index c8d1e53bb..f034cee7e 100644
--- a/kvdb/backend.go
+++ b/kvdb/backend.go
@@ -301,6 +301,4 @@ func GetTestBackend(path, name string) (Backend, func(), error) {
 		}
 		return db, empty, nil
 	}
-
-	return nil, nil, fmt.Errorf("unknown backend")
 }
diff --git a/watchtower/wtclient/session_negotiator.go b/watchtower/wtclient/session_negotiator.go
index 65d5060ae..1f92660db 100644
--- a/watchtower/wtclient/session_negotiator.go
+++ b/watchtower/wtclient/session_negotiator.go
@@ -333,9 +333,6 @@ tryNextCandidate:
 
 			goto retryWithBackoff
 		}
-
-		// Success.
-		return
 	}
 }
 
@@ -393,8 +390,6 @@ func (n *sessionNegotiator) createSession(tower *Tower, keyIndex uint32) error {
 			return nil
 		}
 	}
-
-	return ErrFailedNegotiation
 }
 
 // tryAddress executes a single create session dance using the given address.