From 03899ab1f960ac0b78a03d8676aa2fe4b7317a6b Mon Sep 17 00:00:00 2001
From: Elle Mouton <elle.mouton@gmail.com>
Date: Tue, 18 Feb 2025 10:18:55 -0300
Subject: [PATCH] graph/db: use View directly instead of manual Tx handling

In this commit, we use the available kvdb `View` method directly for
starting a graph session instead of manually creating and commiting the
transaction. Note this changes behaviour since failed tx create/commit
will now error instead of just log.
---
 graph/db/graph.go | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

diff --git a/graph/db/graph.go b/graph/db/graph.go
index 8ee9e86fd..a48e37a5c 100644
--- a/graph/db/graph.go
+++ b/graph/db/graph.go
@@ -18,6 +18,7 @@ import (
 	"github.com/btcsuite/btcd/chaincfg/chainhash"
 	"github.com/btcsuite/btcd/txscript"
 	"github.com/btcsuite/btcd/wire"
+	"github.com/btcsuite/btcwallet/walletdb"
 	"github.com/lightningnetwork/lnd/aliasmgr"
 	"github.com/lightningnetwork/lnd/batch"
 	"github.com/lightningnetwork/lnd/graph/db/models"
@@ -3898,29 +3899,16 @@ func (c *ChannelGraph) IsClosedScid(scid lnwire.ShortChannelID) (bool, error) {
 // the graph cache is not enabled, then the call-back will  be provided with
 // access to the graph via a consistent read-only transaction.
 func (c *ChannelGraph) GraphSession(cb func(graph NodeTraverser) error) error {
-	var (
-		tx     kvdb.RTx
-		err    error
-		commit = func() {}
-	)
-	if c.graphCache == nil {
-		tx, err = c.db.BeginReadTx()
-		if err != nil {
-			return err
-		}
-
-		commit = func() {
-			if err := tx.Rollback(); err != nil {
-				log.Errorf("Unable to rollback tx: %v", err)
-			}
-		}
+	if c.graphCache != nil {
+		return cb(&nodeTraverserSession{db: c})
 	}
-	defer commit()
 
-	return cb(&nodeTraverserSession{
-		db: c,
-		tx: tx,
-	})
+	return c.db.View(func(tx walletdb.ReadTx) error {
+		return cb(&nodeTraverserSession{
+			db: c,
+			tx: tx,
+		})
+	}, func() {})
 }
 
 // nodeTraverserSession implements the NodeTraverser interface but with a