From 17cf90ee34cc706f85dea9f50dae096be9500792 Mon Sep 17 00:00:00 2001 From: Martin Habovstiak Date: Thu, 16 Dec 2021 13:23:53 +0100 Subject: [PATCH] signal: clarify the log message about systemd The log message was confusing because it was emitted even when running within systemd if the service type was **not** `notify`. This clarifies the message by mentioning the edge case. Being able to distinguish the two cases would be nicer but there doesn't seem to be a reasonably simple, obvious, reliable way to do it. Complicated solutions are most likely not worth it for a simple log message. --- docs/release-notes/release-notes-0.14.2.md | 3 +++ signal/signal.go | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/release-notes-0.14.2.md b/docs/release-notes/release-notes-0.14.2.md index 9b3a24555..4514b13ae 100644 --- a/docs/release-notes/release-notes-0.14.2.md +++ b/docs/release-notes/release-notes-0.14.2.md @@ -42,6 +42,9 @@ * [Ensure that the min relay fee is always clamped by our fee floor](https://github.com/lightningnetwork/lnd/pull/6076) +* [Clarify log message about not running within + systemd](https://github.com/lightningnetwork/lnd/pull/6096) + ## RPC Server * [ChanStatusFlags is now diff --git a/signal/signal.go b/signal/signal.go index a9fcaf70f..db1f1eca2 100644 --- a/signal/signal.go +++ b/signal/signal.go @@ -42,7 +42,8 @@ func systemdNotifyReady() error { if notified { log.Info("Systemd was notified about our readiness") } else { - log.Info("We're not running within systemd") + log.Info("We're not running within systemd or the service " + + "type is not 'notify'") } return nil }