From 5793f3df07c9d4c68709e452d89cb8228ccce874 Mon Sep 17 00:00:00 2001 From: yyforyongyu Date: Tue, 16 Jan 2024 16:31:18 +0800 Subject: [PATCH] lnwallet/test: stop creating burning tx in tests bitcoind v25.0 updated the `sendrawtransaction` RPC to have an optional argument `maxburnamount` with a default value of 0. This means our existing test that uses burning output cannot be published, hence, we remove the usage of it in our tests and replace it with a normal tx. --- lnwallet/test/test_interface.go | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lnwallet/test/test_interface.go b/lnwallet/test/test_interface.go index 563a975f8..223bf9a2f 100644 --- a/lnwallet/test/test_interface.go +++ b/lnwallet/test/test_interface.go @@ -1468,15 +1468,20 @@ func testTransactionSubscriptions(miner *rpctest.Harness, // We'll also ensure that the client is able to send our new // notifications when we _create_ transactions ourselves that spend our // own outputs. - b := txscript.NewScriptBuilder() - b.AddOp(txscript.OP_RETURN) - outputScript, err := b.Script() - require.NoError(t, err, "unable to make output script") + addr, err := alice.NewAddress( + lnwallet.WitnessPubKey, false, + lnwallet.DefaultAccountName, + ) + require.NoError(t, err) + + outputScript, err := txscript.PayToAddrScript(addr) + require.NoError(t, err) + burnOutput := wire.NewTxOut(outputAmt, outputScript) tx, err := alice.SendOutputs( []*wire.TxOut{burnOutput}, 2500, 1, labels.External, ) - require.NoError(t, err, "unable to create burn tx") + require.NoError(t, err, "unable to create tx") txid := tx.TxHash() err = waitForMempoolTx(miner, &txid) require.NoError(t, err, "tx not relayed to miner")