highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-12-09 12:22:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

routing: check pubkey when applying channel update

Browse Source
This commit is contained in:
eugene
2022-09-12 16:15:52 -04:00
committed by yyforyongyu
parent 14f45d0722
commit 64b608bce0
3 changed files with 51 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
routing/router_test.go
View File

@@ -385,7 +385,9 @@ func TestChannelUpdateValidation(t *testing.T) {
}, 2),
}
testGraph, err := createTestGraphFromChannels(t, true, testChannels, "a")
testGraph, err := createTestGraphFromChannels(
t, true, testChannels, "a",
)
require.NoError(t, err, "unable to create graph")
const startingBlockHeight = 101
@@ -394,13 +396,13 @@ func TestChannelUpdateValidation(t *testing.T) {
)
// Assert that the initially configured fee is retrieved correctly.
_, policy, _, err := ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1))
_, e1, e2, err := ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1),
)
require.NoError(t, err, "cannot retrieve channel")
require.Equal(t,
feeRate, policy.FeeProportionalMillionths, "invalid fee",
)
require.Equal(t, feeRate, e1.FeeProportionalMillionths, "invalid fee")
require.Equal(t, feeRate, e2.FeeProportionalMillionths, "invalid fee")
// Setup a route from source a to destination c. The route will be used
// in a call to SendToRoute. SendToRoute also applies channel updates,
@@ -430,10 +432,13 @@ func TestChannelUpdateValidation(t *testing.T) {
// returned to the sender.
var invalidSignature [64]byte
errChanUpdate := lnwire.ChannelUpdate{
Signature: invalidSignature,
FeeRate: 500,
ShortChannelID: lnwire.NewShortChanIDFromInt(1),
Timestamp: uint32(testTime.Add(time.Minute).Unix()),
Signature: invalidSignature,
FeeRate: 500,
ShortChannelID: lnwire.NewShortChanIDFromInt(1),
Timestamp: uint32(testTime.Add(time.Minute).Unix()),
MessageFlags: e2.MessageFlags,
ChannelFlags: e2.ChannelFlags,
HtlcMaximumMsat: e2.MaxHTLC,
}
// We'll modify the SendToSwitch method so that it simulates a failed
@@ -459,34 +464,34 @@ func TestChannelUpdateValidation(t *testing.T) {
_, err = ctx.router.SendToRoute(payment, rt)
require.Error(t, err, "expected route to fail with channel update")
_, policy, _, err = ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1))
_, e1, e2, err = ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1),
)
require.NoError(t, err, "cannot retrieve channel")
require.Equal(t,
feeRate, policy.FeeProportionalMillionths,
"fee updated without valid signature",
)
require.Equal(t, feeRate, e1.FeeProportionalMillionths,
"fee updated without valid signature")
require.Equal(t, feeRate, e2.FeeProportionalMillionths,
"fee updated without valid signature")
// Next, add a signature to the channel update.
signErrChanUpdate(t, testGraph.privKeyMap["b"], &errChanUpdate)
// Retry the payment using the same route as before.
_, err = ctx.router.SendToRoute(payment, rt)
if err == nil {
t.Fatalf("expected route to fail with channel update")
}
require.Error(t, err, "expected route to fail with channel update")
// This time a valid signature was supplied and the policy change should
// have been applied to the graph.
_, policy, _, err = ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1))
_, e1, e2, err = ctx.router.GetChannelByID(
lnwire.NewShortChanIDFromInt(1),
)
require.NoError(t, err, "cannot retrieve channel")
require.Equal(t,
lnwire.MilliSatoshi(500), policy.FeeProportionalMillionths,
"fee not updated even though signature is valid",
)
require.Equal(t, feeRate, e1.FeeProportionalMillionths,
"fee should not be updated")
require.EqualValues(t, 500, int(e2.FeeProportionalMillionths),
"fee not updated even though signature is valid")
}
// TestSendPaymentErrorRepeatedFeeInsufficient tests that if we receive