From 2e4318b0ad608ff265dbe15f83254d008bddff9b Mon Sep 17 00:00:00 2001 From: github2k20 Date: Mon, 20 Sep 2021 14:04:26 +0530 Subject: [PATCH 1/2] rpcserver: adds NOT_FOUND status code for LookupInvoice --- rpcserver.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rpcserver.go b/rpcserver.go index 67c510fca..b9e81f3fd 100644 --- a/rpcserver.go +++ b/rpcserver.go @@ -5080,7 +5080,10 @@ func (r *rpcServer) LookupInvoice(ctx context.Context, rpcsLog.Tracef("[lookupinvoice] searching for invoice %x", payHash[:]) invoice, err := r.server.invoices.LookupInvoice(payHash) - if err != nil { + switch { + case err == channeldb.ErrInvoiceNotFound: + return nil, status.Error(codes.NotFound, err.Error()) + case err != nil: return nil, err } From 927a13e51431791cea7ae4b054875321687a69fa Mon Sep 17 00:00:00 2001 From: github2k20 Date: Mon, 20 Sep 2021 20:55:14 +0530 Subject: [PATCH 2/2] docs: Updates release notes for 0.14 --- docs/release-notes/release-notes-0.14.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/release-notes/release-notes-0.14.0.md b/docs/release-notes/release-notes-0.14.0.md index c0717d5b4..6a9827dde 100644 --- a/docs/release-notes/release-notes-0.14.0.md +++ b/docs/release-notes/release-notes-0.14.0.md @@ -105,6 +105,8 @@ proposed channel type is used. allows external tools to hook into `lnd`'s RPC server and intercept any requests made with custom macaroons (and also the responses to those requests). + +* [Adds NOT_FOUND status code for LookupInvoice](https://github.com/lightningnetwork/lnd/pull/5768) ### Batched channel funding @@ -375,6 +377,7 @@ change](https://github.com/lightningnetwork/lnd/pull/5613). * Martin Habovstiak * Naveen Srinivasan * Oliver Gugger +* Priyansh Rastogi * Wilmer Paulino * xanoni * Yong Yu