diff --git a/docs/release-notes/release-notes-0.18.3.md b/docs/release-notes/release-notes-0.18.3.md index 36f2f2b64..372be529c 100644 --- a/docs/release-notes/release-notes-0.18.3.md +++ b/docs/release-notes/release-notes-0.18.3.md @@ -159,6 +159,11 @@ commitment when the channel was force closed. * [Allow](https://github.com/lightningnetwork/lnd/pull/8845) multiple etcd hosts to be specified in db.etcd.host. +* Improved the internal [`LeaseOutput` + method](https://github.com/lightningnetwork/lnd/pull/8961) to be more + efficient, which improves the performance of related RPC calls such as + `LeaseOutput`, `SendCoins`, and PSBT funding process. + ## RPC Updates * [`xImportMissionControl`](https://github.com/lightningnetwork/lnd/pull/8779) diff --git a/go.mod b/go.mod index 99d861c38..f82781766 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( github.com/btcsuite/btcd/btcutil/psbt v1.1.8 github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0 github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f - github.com/btcsuite/btcwallet v0.16.10-0.20240718224643-db3a4a2543bd + github.com/btcsuite/btcwallet v0.16.10-0.20240809133323-7d3434c65ae2 github.com/btcsuite/btcwallet/wallet/txauthor v1.3.4 github.com/btcsuite/btcwallet/wallet/txrules v1.2.1 github.com/btcsuite/btcwallet/walletdb v1.4.2 diff --git a/go.sum b/go.sum index 0d49f76e3..d040d8cf8 100644 --- a/go.sum +++ b/go.sum @@ -92,8 +92,8 @@ github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0/go.mod h1:7SFka0XMvUgj3hfZtyd github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f h1:bAs4lUbRJpnnkd9VhRV3jjAVU7DJVjMaK+IsvSeZvFo= github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f/go.mod h1:TdznJufoqS23FtqVCzL0ZqgP5MqXbb4fg/WgDys70nA= github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d/go.mod h1:+5NJ2+qvTyV9exUAL/rxXi3DcLg2Ts+ymUAY5y4NvMg= -github.com/btcsuite/btcwallet v0.16.10-0.20240718224643-db3a4a2543bd h1:QDb8foTCRoXrfoZVEzSYgSde16MJh4gCtCin8OCS0kI= -github.com/btcsuite/btcwallet v0.16.10-0.20240718224643-db3a4a2543bd/go.mod h1:X2xDre+j1QphTRo54y2TikUzeSvreL1t1aMXrD8Kc5A= +github.com/btcsuite/btcwallet v0.16.10-0.20240809133323-7d3434c65ae2 h1:qa4Avm7p97JroZZyMJADbEb9u853pjleJYSeitENvLc= +github.com/btcsuite/btcwallet v0.16.10-0.20240809133323-7d3434c65ae2/go.mod h1:X2xDre+j1QphTRo54y2TikUzeSvreL1t1aMXrD8Kc5A= github.com/btcsuite/btcwallet/wallet/txauthor v1.3.4 h1:poyHFf7+5+RdxNp5r2T6IBRD7RyraUsYARYbp/7t4D8= github.com/btcsuite/btcwallet/wallet/txauthor v1.3.4/go.mod h1:GETGDQuyq+VFfH1S/+/7slLM/9aNa4l7P4ejX6dJfb0= github.com/btcsuite/btcwallet/wallet/txrules v1.2.1 h1:UZo7YRzdHbwhK7Rhv3PO9bXgTxiOH45edK5qdsdiatk= diff --git a/itest/lnd_hold_invoice_force_test.go b/itest/lnd_hold_invoice_force_test.go index 2b251b3cb..7c616e7a5 100644 --- a/itest/lnd_hold_invoice_force_test.go +++ b/itest/lnd_hold_invoice_force_test.go @@ -95,10 +95,6 @@ func testHoldInvoiceForceClose(ht *lntest.HarnessTest) { // We first mine enough blocks to trigger an invoice cancelation. ht.MineBlocks(int(blocksTillCancel)) - // Wait for the nodes to be synced. - ht.WaitForBlockchainSync(alice) - ht.WaitForBlockchainSync(bob) - // Check that the invoice is canceled by Bob. err := wait.NoError(func() error { inv := bob.RPC.LookupInvoice(payHash[:]) @@ -135,10 +131,6 @@ func testHoldInvoiceForceClose(ht *lntest.HarnessTest) { // invoice cancelation message was received by Alice. ht.MineBlocks(int(blocksTillForce - blocksTillCancel)) - // Wait for the nodes to be synced. - ht.WaitForBlockchainSync(alice) - ht.WaitForBlockchainSync(bob) - // Check that Alice has not closed the channel because there are no // outgoing HTLCs in her channel as the only HTLC has already been // canceled. diff --git a/itest/lnd_psbt_test.go b/itest/lnd_psbt_test.go index 91d67ba37..ac39bb497 100644 --- a/itest/lnd_psbt_test.go +++ b/itest/lnd_psbt_test.go @@ -1578,7 +1578,6 @@ func sendAllCoinsToAddrType(ht *lntest.HarnessTest, }) ht.MineBlocksAndAssertNumTxes(1, 1) - ht.WaitForBlockchainSync(hn) } // testPsbtChanFundingFailFlow tests the failing of a funding flow by the diff --git a/itest/lnd_route_blinding_test.go b/itest/lnd_route_blinding_test.go index 44d5879f9..fbfca0f27 100644 --- a/itest/lnd_route_blinding_test.go +++ b/itest/lnd_route_blinding_test.go @@ -852,10 +852,6 @@ func testErrorHandlingOnChainFailure(ht *lntest.HarnessTest) { ht.AssertNumPendingSweeps(ht.Bob, 0) ht.MineBlocksAndAssertNumTxes(1, 1) - // Assert that the HTLC has cleared. - ht.WaitForBlockchainSync(ht.Bob) - ht.WaitForBlockchainSync(ht.Alice) - ht.AssertHTLCNotActive(ht.Bob, testCase.channels[0], hash[:]) ht.AssertHTLCNotActive(ht.Alice, testCase.channels[0], hash[:]) diff --git a/lnrpc/walletrpc/psbt.go b/lnrpc/walletrpc/psbt.go index 19b102473..057751964 100644 --- a/lnrpc/walletrpc/psbt.go +++ b/lnrpc/walletrpc/psbt.go @@ -56,7 +56,13 @@ func lockInputs(w lnwallet.WalletController, }, } - expiration, pkScript, value, err := w.LeaseOutput( + // Get the details about this outpoint. + utxo, err := w.FetchOutpointInfo(&lock.Outpoint) + if err != nil { + return nil, fmt.Errorf("fetch outpoint info: %w", err) + } + + expiration, err := w.LeaseOutput( lock.LockID, lock.Outpoint, chanfunding.DefaultLockDuration, ) @@ -80,8 +86,8 @@ func lockInputs(w lnwallet.WalletController, } lock.Expiration = expiration - lock.PkScript = pkScript - lock.Value = int64(value) + lock.PkScript = utxo.PkScript + lock.Value = int64(utxo.Value) locks[idx] = lock } diff --git a/lnrpc/walletrpc/walletkit_server.go b/lnrpc/walletrpc/walletkit_server.go index fc24ae13e..5ed33cdc8 100644 --- a/lnrpc/walletrpc/walletkit_server.go +++ b/lnrpc/walletrpc/walletkit_server.go @@ -496,7 +496,7 @@ func (w *WalletKit) LeaseOutput(ctx context.Context, // other concurrent processes attempting to lease the same UTXO. var expiration time.Time err = w.cfg.CoinSelectionLocker.WithCoinSelectLock(func() error { - expiration, _, _, err = w.cfg.Wallet.LeaseOutput( + expiration, err = w.cfg.Wallet.LeaseOutput( lockID, *op, duration, ) return err @@ -1296,7 +1296,7 @@ func (w *WalletKit) sweepNewInput(op *wire.OutPoint, currentHeight uint32, // // We'll gather all of the information required by the UtxoSweeper in // order to sweep the output. - utxo, err := w.cfg.Wallet.FetchInputInfo(op) + utxo, err := w.cfg.Wallet.FetchOutpointInfo(op) if err != nil { return err } diff --git a/lntest/mock/walletcontroller.go b/lntest/mock/walletcontroller.go index 7af22e038..cb7e38701 100644 --- a/lntest/mock/walletcontroller.go +++ b/lntest/mock/walletcontroller.go @@ -43,9 +43,9 @@ func (w *WalletController) BackEnd() string { return "mock" } -// FetchInputInfo will be called to get info about the inputs to the funding +// FetchOutpointInfo will be called to get info about the inputs to the funding // transaction. -func (w *WalletController) FetchInputInfo( +func (w *WalletController) FetchOutpointInfo( prevOut *wire.OutPoint) (*lnwallet.Utxo, error) { utxo := &lnwallet.Utxo{ @@ -195,9 +195,9 @@ func (w *WalletController) ListTransactionDetails(int32, int32, // LeaseOutput returns the current time and a nil error. func (w *WalletController) LeaseOutput(wtxmgr.LockID, wire.OutPoint, - time.Duration) (time.Time, []byte, btcutil.Amount, error) { + time.Duration) (time.Time, error) { - return time.Now(), nil, 0, nil + return time.Now(), nil } // ReleaseOutput currently does nothing. @@ -292,3 +292,11 @@ func (w *WalletController) RemoveDescendants(*wire.MsgTx) error { func (w *WalletController) CheckMempoolAcceptance(tx *wire.MsgTx) error { return nil } + +// FetchDerivationInfo queries for the wallet's knowledge of the passed +// pkScript and constructs the derivation info and returns it. +func (w *WalletController) FetchDerivationInfo( + pkScript []byte) (*psbt.Bip32Derivation, error) { + + return nil, nil +} diff --git a/lnwallet/btcwallet/btcwallet.go b/lnwallet/btcwallet/btcwallet.go index e796c4322..d0444edd5 100644 --- a/lnwallet/btcwallet/btcwallet.go +++ b/lnwallet/btcwallet/btcwallet.go @@ -1079,36 +1079,20 @@ func (b *BtcWallet) CreateSimpleTx(inputs fn.Set[wire.OutPoint], // // NOTE: This method requires the global coin selection lock to be held. func (b *BtcWallet) LeaseOutput(id wtxmgr.LockID, op wire.OutPoint, - duration time.Duration) (time.Time, []byte, btcutil.Amount, error) { + duration time.Duration) (time.Time, error) { // Make sure we don't attempt to double lock an output that's been // locked by the in-memory implementation. if b.wallet.LockedOutpoint(op) { - return time.Time{}, nil, 0, wtxmgr.ErrOutputAlreadyLocked + return time.Time{}, wtxmgr.ErrOutputAlreadyLocked } lockedUntil, err := b.wallet.LeaseOutput(id, op, duration) if err != nil { - return time.Time{}, nil, 0, err + return time.Time{}, err } - // Get the pkScript and value for this lock from the list of all leased - // outputs. - allLeases, err := b.wallet.ListLeasedOutputs() - if err != nil { - return time.Time{}, nil, 0, err - } - - for _, lease := range allLeases { - if lease.Outpoint == op { - return lockedUntil, lease.PkScript, - btcutil.Amount(lease.Value), nil - } - } - - // We MUST find the leased output in the loop above, otherwise something - // is seriously wrong. - return time.Time{}, nil, 0, wtxmgr.ErrUnknownOutput + return lockedUntil, nil } // ListLeasedOutputs returns a list of all currently locked outputs. diff --git a/lnwallet/btcwallet/signer.go b/lnwallet/btcwallet/signer.go index 986416476..97832a789 100644 --- a/lnwallet/btcwallet/signer.go +++ b/lnwallet/btcwallet/signer.go @@ -8,6 +8,7 @@ import ( "github.com/btcsuite/btcd/btcec/v2/schnorr" "github.com/btcsuite/btcd/btcutil" "github.com/btcsuite/btcd/btcutil/hdkeychain" + "github.com/btcsuite/btcd/btcutil/psbt" "github.com/btcsuite/btcd/chaincfg/chainhash" "github.com/btcsuite/btcd/txscript" "github.com/btcsuite/btcd/wire" @@ -18,18 +19,16 @@ import ( "github.com/lightningnetwork/lnd/lnwallet" ) -// FetchInputInfo queries for the WalletController's knowledge of the passed +// FetchOutpointInfo queries for the WalletController's knowledge of the passed // outpoint. If the base wallet determines this output is under its control, // then the original txout should be returned. Otherwise, a non-nil error value // of ErrNotMine should be returned instead. // // This is a part of the WalletController interface. -func (b *BtcWallet) FetchInputInfo(prevOut *wire.OutPoint) (*lnwallet.Utxo, +func (b *BtcWallet) FetchOutpointInfo(prevOut *wire.OutPoint) (*lnwallet.Utxo, error) { - prevTx, txOut, bip32, confirmations, err := b.wallet.FetchInputInfo( - prevOut, - ) + prevTx, txOut, confirmations, err := b.wallet.FetchOutpointInfo(prevOut) if err != nil { return nil, err } @@ -51,11 +50,18 @@ func (b *BtcWallet) FetchInputInfo(prevOut *wire.OutPoint) (*lnwallet.Utxo, PkScript: txOut.PkScript, Confirmations: confirmations, OutPoint: *prevOut, - Derivation: bip32, PrevTx: prevTx, }, nil } +// FetchDerivationInfo queries for the wallet's knowledge of the passed +// pkScript and constructs the derivation info and returns it. +func (b *BtcWallet) FetchDerivationInfo( + pkScript []byte) (*psbt.Bip32Derivation, error) { + + return b.wallet.FetchDerivationInfo(pkScript) +} + // ScriptForOutput returns the address, witness program and redeem script for a // given UTXO. An error is returned if the UTXO does not belong to our wallet or // it is not a managed pubKey address. diff --git a/lnwallet/chanfunding/assembler.go b/lnwallet/chanfunding/assembler.go index a694d2a2c..2fdb87b32 100644 --- a/lnwallet/chanfunding/assembler.go +++ b/lnwallet/chanfunding/assembler.go @@ -44,7 +44,7 @@ type OutputLeaser interface { // LeaseOutput leases a target output, rendering it unusable for coin // selection. LeaseOutput(i wtxmgr.LockID, o wire.OutPoint, d time.Duration) ( - time.Time, []byte, btcutil.Amount, error) + time.Time, error) // ReleaseOutput releases a target output, allowing it to be used for // coin selection once again. diff --git a/lnwallet/chanfunding/wallet_assembler.go b/lnwallet/chanfunding/wallet_assembler.go index 4f2aa759b..f824210e1 100644 --- a/lnwallet/chanfunding/wallet_assembler.go +++ b/lnwallet/chanfunding/wallet_assembler.go @@ -525,7 +525,7 @@ func (w *WalletAssembler) ProvisionChannel(r *Request) (Intent, error) { for _, coin := range selectedCoins { outpoint := coin.OutPoint - _, _, _, err = w.cfg.CoinLeaser.LeaseOutput( + _, err = w.cfg.CoinLeaser.LeaseOutput( LndInternalLockID, outpoint, DefaultReservationTimeout, ) diff --git a/lnwallet/interface.go b/lnwallet/interface.go index af5955d8e..d3b123509 100644 --- a/lnwallet/interface.go +++ b/lnwallet/interface.go @@ -126,8 +126,7 @@ type Utxo struct { Confirmations int64 PkScript []byte wire.OutPoint - Derivation *psbt.Bip32Derivation - PrevTx *wire.MsgTx + PrevTx *wire.MsgTx } // OutputDetail contains additional information on a destination address. @@ -227,11 +226,16 @@ type TransactionSubscription interface { // behavior of all interface methods in order to ensure identical behavior // across all concrete implementations. type WalletController interface { - // FetchInputInfo queries for the WalletController's knowledge of the - // passed outpoint. If the base wallet determines this output is under - // its control, then the original txout should be returned. Otherwise, - // a non-nil error value of ErrNotMine should be returned instead. - FetchInputInfo(prevOut *wire.OutPoint) (*Utxo, error) + // FetchOutpointInfo queries for the WalletController's knowledge of + // the passed outpoint. If the base wallet determines this output is + // under its control, then the original txout should be returned. + // Otherwise, a non-nil error value of ErrNotMine should be returned + // instead. + FetchOutpointInfo(prevOut *wire.OutPoint) (*Utxo, error) + + // FetchDerivationInfo queries for the wallet's knowledge of the passed + // pkScript and constructs the derivation info and returns it. + FetchDerivationInfo(pkScript []byte) (*psbt.Bip32Derivation, error) // ScriptForOutput returns the address, witness program and redeem // script for a given UTXO. An error is returned if the UTXO does not @@ -409,8 +413,7 @@ type WalletController interface { // // NOTE: This method requires the global coin selection lock to be held. LeaseOutput(id wtxmgr.LockID, op wire.OutPoint, - duration time.Duration) (time.Time, []byte, btcutil.Amount, - error) + duration time.Duration) (time.Time, error) // ReleaseOutput unlocks an output, allowing it to be available for coin // selection if it remains unspent. The ID should match the one used to diff --git a/lnwallet/mock.go b/lnwallet/mock.go index e6bd0b2e4..faac5fa67 100644 --- a/lnwallet/mock.go +++ b/lnwallet/mock.go @@ -45,9 +45,9 @@ func (w *mockWalletController) BackEnd() string { return "mock" } -// FetchInputInfo will be called to get info about the inputs to the funding +// FetchOutpointInfo will be called to get info about the inputs to the funding // transaction. -func (w *mockWalletController) FetchInputInfo( +func (w *mockWalletController) FetchOutpointInfo( prevOut *wire.OutPoint) (*Utxo, error) { utxo := &Utxo{ @@ -201,9 +201,9 @@ func (w *mockWalletController) ListTransactionDetails(int32, int32, // LeaseOutput returns the current time and a nil error. func (w *mockWalletController) LeaseOutput(wtxmgr.LockID, wire.OutPoint, - time.Duration) (time.Time, []byte, btcutil.Amount, error) { + time.Duration) (time.Time, error) { - return time.Now(), nil, 0, nil + return time.Now(), nil } // ReleaseOutput currently does nothing. @@ -300,6 +300,14 @@ func (w *mockWalletController) RemoveDescendants(*wire.MsgTx) error { return nil } +// FetchDerivationInfo queries for the wallet's knowledge of the passed +// pkScript and constructs the derivation info and returns it. +func (w *mockWalletController) FetchDerivationInfo( + pkScript []byte) (*psbt.Bip32Derivation, error) { + + return nil, nil +} + func (w *mockWalletController) CheckMempoolAcceptance(tx *wire.MsgTx) error { return nil } diff --git a/lnwallet/rpcwallet/rpcwallet.go b/lnwallet/rpcwallet/rpcwallet.go index c70217416..bf6aa61df 100644 --- a/lnwallet/rpcwallet/rpcwallet.go +++ b/lnwallet/rpcwallet/rpcwallet.go @@ -154,7 +154,7 @@ func (r *RPCKeyRing) SendOutputs(inputs fn.Set[wire.OutPoint], // watch-only wallet if it can map this outpoint into a coin we // own. If not, then we can't continue because our wallet state // is out of sync. - info, err := r.WalletController.FetchInputInfo( + info, err := r.WalletController.FetchOutpointInfo( &txIn.PreviousOutPoint, ) if err != nil { @@ -289,7 +289,7 @@ func (r *RPCKeyRing) FinalizePsbt(packet *psbt.Packet, _ string) error { // We can only sign this input if it's ours, so we try to map it // to a coin we own. If we can't, then we'll continue as it // isn't our input. - utxo, err := r.FetchInputInfo(&txIn.PreviousOutPoint) + utxo, err := r.FetchOutpointInfo(&txIn.PreviousOutPoint) if err != nil { continue } @@ -906,7 +906,7 @@ func (r *RPCKeyRing) remoteSign(tx *wire.MsgTx, signDesc *input.SignDescriptor, } txIn := tx.TxIn[idx] - info, err := r.WalletController.FetchInputInfo( + info, err := r.WalletController.FetchOutpointInfo( &txIn.PreviousOutPoint, ) if err != nil { @@ -1015,19 +1015,32 @@ func (r *RPCKeyRing) remoteSign(tx *wire.MsgTx, signDesc *input.SignDescriptor, signDesc.KeyDesc.PubKey = fullDesc.PubKey } + var derivation *psbt.Bip32Derivation + // Make sure we actually know about the input. We either have been // watching the UTXO on-chain or we have been given all the required // info in the sign descriptor. - info, err := r.WalletController.FetchInputInfo(&txIn.PreviousOutPoint) + info, err := r.WalletController.FetchOutpointInfo( + &txIn.PreviousOutPoint, + ) + + // If the wallet is aware of this outpoint, we go ahead and fetch the + // derivation info. + if err == nil { + derivation, err = r.WalletController.FetchDerivationInfo( + info.PkScript, + ) + } + switch { - // No error, we do have the full UTXO and derivation info available. + // No error, we do have the full UTXO info available. case err == nil: in.WitnessUtxo = &wire.TxOut{ Value: int64(info.Value), PkScript: info.PkScript, } in.NonWitnessUtxo = info.PrevTx - in.Bip32Derivation = []*psbt.Bip32Derivation{info.Derivation} + in.Bip32Derivation = []*psbt.Bip32Derivation{derivation} // The wallet doesn't know about this UTXO, so it's probably a TX that // we haven't published yet (e.g. a channel funding TX). So we need to diff --git a/lnwallet/wallet.go b/lnwallet/wallet.go index 90a0bea2d..6925446a3 100644 --- a/lnwallet/wallet.go +++ b/lnwallet/wallet.go @@ -1646,7 +1646,7 @@ func (l *LightningWallet) handleContributionMsg(req *addContributionMsg) { []*input.Script, 0, len(ourContribution.Inputs), ) for _, txIn := range fundingTx.TxIn { - _, err := l.FetchInputInfo(&txIn.PreviousOutPoint) + _, err := l.FetchOutpointInfo(&txIn.PreviousOutPoint) if err != nil { continue } @@ -2592,7 +2592,7 @@ func (c *CoinSource) ListCoins(minConfs int32, // its outpoint. If the coin isn't under the control of the backing CoinSource, // then an error should be returned. func (c *CoinSource) CoinFromOutPoint(op wire.OutPoint) (*wallet.Coin, error) { - inputInfo, err := c.wallet.FetchInputInfo(&op) + inputInfo, err := c.wallet.FetchOutpointInfo(&op) if err != nil { return nil, err } @@ -2689,7 +2689,7 @@ func NewWalletPrevOutputFetcher(wc WalletController) *WalletPrevOutputFetcher { // passed outpoint. A nil value will be returned if the passed outpoint doesn't // exist. func (w *WalletPrevOutputFetcher) FetchPrevOutput(op wire.OutPoint) *wire.TxOut { - utxo, err := w.wc.FetchInputInfo(&op) + utxo, err := w.wc.FetchOutpointInfo(&op) if err != nil { return nil } diff --git a/rpcserver.go b/rpcserver.go index 7c2c06674..cd2198e28 100644 --- a/rpcserver.go +++ b/rpcserver.go @@ -3488,14 +3488,7 @@ func (r *rpcServer) WalletBalance(ctx context.Context, return nil, err } for _, leasedOutput := range leases { - utxoInfo, err := r.server.cc.Wallet.FetchInputInfo( - &leasedOutput.Outpoint, - ) - if err != nil { - return nil, err - } - - lockedBalance += utxoInfo.Value + lockedBalance += btcutil.Amount(leasedOutput.Value) } // Get the current number of non-private anchor channels. diff --git a/sweep/walletsweep.go b/sweep/walletsweep.go index 919e5f1d5..da5e56dee 100644 --- a/sweep/walletsweep.go +++ b/sweep/walletsweep.go @@ -179,7 +179,7 @@ type OutputLeaser interface { // LeaseOutput leases a target output, rendering it unusable for coin // selection. LeaseOutput(i wtxmgr.LockID, o wire.OutPoint, d time.Duration) ( - time.Time, []byte, btcutil.Amount, error) + time.Time, error) // ReleaseOutput releases a target output, allowing it to be used for // coin selection once again. @@ -284,7 +284,7 @@ func CraftSweepAllTx(feeRate, maxFeeRate chainfee.SatPerKWeight, log.Tracef("[WithCoinSelectLock] leasing utxo: %v", utxo.OutPoint) - _, _, _, err = outputLeaser.LeaseOutput( + _, err = outputLeaser.LeaseOutput( chanfunding.LndInternalLockID, utxo.OutPoint, chanfunding.DefaultLockDuration, ) diff --git a/sweep/walletsweep_test.go b/sweep/walletsweep_test.go index f5ed0283e..968d9cb4f 100644 --- a/sweep/walletsweep_test.go +++ b/sweep/walletsweep_test.go @@ -199,11 +199,11 @@ func newMockOutputLeaser() *mockOutputLeaser { } func (m *mockOutputLeaser) LeaseOutput(_ wtxmgr.LockID, o wire.OutPoint, - t time.Duration) (time.Time, []byte, btcutil.Amount, error) { + t time.Duration) (time.Time, error) { m.leasedOutputs[o] = struct{}{} - return time.Now().Add(t), nil, 0, nil + return time.Now().Add(t), nil } func (m *mockOutputLeaser) ReleaseOutput(_ wtxmgr.LockID,