From 6a1283cf0b9224bc9926868710d2d301ee17d8d5 Mon Sep 17 00:00:00 2001 From: Alex Bosworth Date: Fri, 22 Oct 2021 13:20:55 -0700 Subject: [PATCH 1/2] lnrpc: log channel point in coop close warning Use `Warnf` to include the chanpoint in the warning message instead of printing `%v` to the log --- rpcserver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpcserver.go b/rpcserver.go index a204538e0..9b15348ab 100644 --- a/rpcserver.go +++ b/rpcserver.go @@ -3312,7 +3312,7 @@ func (r *rpcServer) PendingChannels(ctx context.Context, // state. We log a warning that the channel will not be included // in the now deprecated pending close channels field. case channeldb.CooperativeClose: - rpcsLog.Warn("channel %v cooperatively closed and "+ + rpcsLog.Warnf("channel %v cooperatively closed and "+ "in pending close state", pendingClose.ChanPoint) From 262992fbe33b8e96e1046c12e5e8cb7d8c775ffa Mon Sep 17 00:00:00 2001 From: Alex Bosworth Date: Fri, 22 Oct 2021 13:57:10 -0700 Subject: [PATCH 2/2] include release note --- docs/release-notes/release-notes-0.14.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/release-notes/release-notes-0.14.0.md b/docs/release-notes/release-notes-0.14.0.md index 221051680..601627843 100644 --- a/docs/release-notes/release-notes-0.14.0.md +++ b/docs/release-notes/release-notes-0.14.0.md @@ -335,6 +335,8 @@ messages directly. There is no routing/path finding involved. ### Code cleanup, refactor, typo fixes +* [Fix logging typo to log channel point on cooperative closes](https://github.com/lightningnetwork/lnd/pull/5881) + * [Refactor the interaction between the `htlcswitch` and `peer` packages for cleaner separation.](https://github.com/lightningnetwork/lnd/pull/5603) * [Moved the original breach handling and timelock UTXO handling into the contract court package](https://github.com/lightningnetwork/lnd/pull/5745) @@ -534,6 +536,7 @@ requirements surrounding updating the release notes for each new change](https://github.com/lightningnetwork/lnd/pull/5613). # Contributors (Alphabetical Order) +* Alex Bosworth * Alyssa Hertig * Andras Banki-Horvath * de6df1re