From f0ba4be758ffc218dd59a5c4886223013ca63ccc Mon Sep 17 00:00:00 2001 From: "Johan T. Halseth" Date: Wed, 18 Sep 2019 13:25:12 +0200 Subject: [PATCH] autopilot/manager: fix slice modifications When appending to a slice, there is no guarantee the slice won't be modified. So instead of appending to the global slice availableHeuristics, we create a temporary local one. --- autopilot/manager.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/autopilot/manager.go b/autopilot/manager.go index 3253fdaf6..86e0e08b3 100644 --- a/autopilot/manager.go +++ b/autopilot/manager.go @@ -319,8 +319,12 @@ func (m *Manager) queryHeuristics(nodes map[NodeID]struct{}, localState bool) ( // We'll start by getting the scores from each available sub-heuristic, // in addition the current agent heuristic. + var heuristics []AttachmentHeuristic + heuristics = append(heuristics, availableHeuristics...) + heuristics = append(heuristics, m.cfg.PilotCfg.Heuristic) + report := make(HeuristicScores) - for _, h := range append(availableHeuristics, m.cfg.PilotCfg.Heuristic) { + for _, h := range heuristics { name := h.Name() // If the agent heuristic is among the simple heuristics it