From 145fd3c19ab90840f4c97ee72eb525e579ccef97 Mon Sep 17 00:00:00 2001 From: Naiyuan Qing <145280634+NevilleQingNY@users.noreply.github.com> Date: Fri, 24 Jul 2026 15:43:15 +0800 Subject: [PATCH] chore(views): remove orphaned tool_calls i18n keys, fix inline-variant JSDoc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review follow-ups (no behavior change): - Delete tool_calls_one/tool_calls_other from all four locales — the metadata chip that used them was removed earlier in this branch. - Correct the AttributionBadge inline-variant JSDoc: it renders the bare name (no "on behalf of" wrapper), matching the implementation and test. - en events_one grammar: "1 event" not "1 events". Co-Authored-By: Claude Fable 5 --- packages/views/issues/components/attribution-badge.tsx | 6 ++++-- packages/views/locales/en/agents.json | 4 +--- packages/views/locales/ja/agents.json | 1 - packages/views/locales/ko/agents.json | 1 - packages/views/locales/zh-Hans/agents.json | 1 - 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/views/issues/components/attribution-badge.tsx b/packages/views/issues/components/attribution-badge.tsx index 2e94cb651..d31f72e2f 100644 --- a/packages/views/issues/components/attribution-badge.tsx +++ b/packages/views/issues/components/attribution-badge.tsx @@ -39,8 +39,10 @@ function initialsOf(name: string): string { * source in a hover tooltip. Compact enough for a dense task row. Renders * nothing when there's no accountable member — an avatar-only surface has * nothing meaningful to show for an unattributed run. - * - `variant="inline"`: avatar + borderless "on behalf of " text for a - * sentence-like identity row (transcript header). Same silence rule. + * - `variant="inline"`: the bare member name (borderless, avatar optional via + * `hideAvatar`) with the source in a tooltip — for a sentence-like identity + * row (transcript header) where the caller supplies the label. Same silence + * rule. * * Renders nothing when the task has no attribution at all (older backends) — * the caller should optional-chain `task.attribution`. diff --git a/packages/views/locales/en/agents.json b/packages/views/locales/en/agents.json index f2b81ab56..d90736c49 100644 --- a/packages/views/locales/en/agents.json +++ b/packages/views/locales/en/agents.json @@ -765,9 +765,7 @@ "status_failed": "Failed", "filter": "Filter", "clear_filters": "Clear filters", - "tool_calls_one": "{{count}} tool call", - "tool_calls_other": "{{count}} tool calls", - "events_one": "{{count}} events", + "events_one": "{{count}} event", "events_other": "{{count}} events", "events_filtered": "{{shown}} of {{total}} events", "copy_all": "Copy all", diff --git a/packages/views/locales/ja/agents.json b/packages/views/locales/ja/agents.json index 23cb16fc2..6883be709 100644 --- a/packages/views/locales/ja/agents.json +++ b/packages/views/locales/ja/agents.json @@ -647,7 +647,6 @@ "status_failed": "失敗", "filter": "フィルター", "clear_filters": "フィルターをクリア", - "tool_calls_other": "ツール呼び出し {{count}} 回", "events_other": "イベント {{count}} 件", "events_filtered": "イベント {{total}} 件中 {{shown}} 件", "copy_all": "すべてコピー", diff --git a/packages/views/locales/ko/agents.json b/packages/views/locales/ko/agents.json index e715f46ea..75fe4483f 100644 --- a/packages/views/locales/ko/agents.json +++ b/packages/views/locales/ko/agents.json @@ -655,7 +655,6 @@ "status_failed": "실패함", "filter": "필터", "clear_filters": "필터 지우기", - "tool_calls_other": "도구 호출 {{count}}회", "events_other": "이벤트 {{count}}개", "events_filtered": "이벤트 {{total}}개 중 {{shown}}개", "copy_all": "전체 복사", diff --git a/packages/views/locales/zh-Hans/agents.json b/packages/views/locales/zh-Hans/agents.json index cbf480e3d..e316315e0 100644 --- a/packages/views/locales/zh-Hans/agents.json +++ b/packages/views/locales/zh-Hans/agents.json @@ -751,7 +751,6 @@ "status_failed": "失败", "filter": "筛选", "clear_filters": "清除筛选", - "tool_calls_other": "{{count}} 次工具调用", "events_other": "{{count}} 个事件", "events_filtered": "{{shown}} / {{total}} 个事件", "copy_all": "全部复制",