From 98ba6cba3169a359f25fb5454a7b06e690b58469 Mon Sep 17 00:00:00 2001 From: Jiayuan Date: Fri, 23 Jan 2026 16:08:17 +0800 Subject: [PATCH 1/4] ci: enable CI for pull requests to dev branch Add dev branch to the pull_request trigger so that CI runs on PRs to dev, matching the configuration for main branch. Co-Authored-By: Claude Haiku 4.5 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index afd4dcee56..fd5505f05f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: push: branches: ['*'] pull_request: - branches: [main] + branches: [main, dev] jobs: ci: From 58817b651f39f82602838264cde38548ee85df3e Mon Sep 17 00:00:00 2001 From: Jiayuan Date: Fri, 23 Jan 2026 16:10:34 +0800 Subject: [PATCH 2/4] fix: remove unused React import in FileTreeComponent test Co-Authored-By: Claude Haiku 4.5 --- tests/unit/renderer/components/FileTreeComponent.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/renderer/components/FileTreeComponent.test.tsx b/tests/unit/renderer/components/FileTreeComponent.test.tsx index d6e6a31d0d..1e8be18b19 100644 --- a/tests/unit/renderer/components/FileTreeComponent.test.tsx +++ b/tests/unit/renderer/components/FileTreeComponent.test.tsx @@ -1,7 +1,7 @@ /** * @vitest-environment jsdom */ -import React, { act } from 'react' +import { act } from 'react' import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' import { createRoot, type Root } from 'react-dom/client' import { FileTree } from '../../../../src/renderer/src/components/FileTree' From 0833a6e9729ab18da3ffbea72de96c98131bd8e9 Mon Sep 17 00:00:00 2001 From: Jiayuan Date: Fri, 23 Jan 2026 16:15:15 +0800 Subject: [PATCH 3/4] fix: CI test failures - Add React import back in FileTreeComponent.test.tsx (required for JSX) - Fix isValidPath to recognize Windows paths on non-Windows platforms Co-Authored-By: Claude Haiku 4.5 --- src/main/utils/pathValidation.ts | 7 ++++++- tests/unit/renderer/components/FileTreeComponent.test.tsx | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/utils/pathValidation.ts b/src/main/utils/pathValidation.ts index 0bb7db0006..2ea799e062 100644 --- a/src/main/utils/pathValidation.ts +++ b/src/main/utils/pathValidation.ts @@ -1,7 +1,12 @@ import * as path from 'path' +// Regex to match Windows absolute paths (e.g., C:\Users or D:\) +const WINDOWS_ABSOLUTE_PATH_REGEX = /^[a-zA-Z]:[/\\]/ + export function isValidPath(inputPath: string): boolean { - if (!path.isAbsolute(inputPath)) { + // Check for absolute path (POSIX or Windows) + const isAbsolute = path.isAbsolute(inputPath) || WINDOWS_ABSOLUTE_PATH_REGEX.test(inputPath) + if (!isAbsolute) { return false } diff --git a/tests/unit/renderer/components/FileTreeComponent.test.tsx b/tests/unit/renderer/components/FileTreeComponent.test.tsx index 1e8be18b19..6b7420bb71 100644 --- a/tests/unit/renderer/components/FileTreeComponent.test.tsx +++ b/tests/unit/renderer/components/FileTreeComponent.test.tsx @@ -1,6 +1,7 @@ /** * @vitest-environment jsdom */ +import * as React from 'react' import { act } from 'react' import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' import { createRoot, type Root } from 'react-dom/client' From bed7097e128737da7449aa979f6488b35cc199e1 Mon Sep 17 00:00:00 2001 From: Jiayuan Date: Fri, 23 Jan 2026 16:17:59 +0800 Subject: [PATCH 4/4] fix: disable eslint warning for React import in test React import is required for JSX but eslint flags it as unused. Co-Authored-By: Claude Haiku 4.5 --- tests/unit/renderer/components/FileTreeComponent.test.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/renderer/components/FileTreeComponent.test.tsx b/tests/unit/renderer/components/FileTreeComponent.test.tsx index 6b7420bb71..b6ab0f23c4 100644 --- a/tests/unit/renderer/components/FileTreeComponent.test.tsx +++ b/tests/unit/renderer/components/FileTreeComponent.test.tsx @@ -1,6 +1,7 @@ /** * @vitest-environment jsdom */ +// eslint-disable-next-line @typescript-eslint/no-unused-vars import * as React from 'react' import { act } from 'react' import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'