From ae8ea8a3939c4154791e4e08f6c227d3aef9dbe0 Mon Sep 17 00:00:00 2001 From: Naiyuan Qing <145280634+NevilleQingNY@users.noreply.github.com> Date: Tue, 12 May 2026 11:27:28 +0800 Subject: [PATCH] refactor(feedback): replace generic description with brand-colored GitHub CTA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Feedback modal previously rendered three lines of grey copy before the editor — title, description, and the GitHub hint from #2451. The hint blended into the description, defeating its purpose of nudging users toward a tracked channel. Drop the generic description (placeholder already explains what to type) and restyle the hint so GitHub itself is the only brand-coloured anchor. The shorter sentence ("Want faster traction? Head to GitHub") puts the link at the natural end-of-line fixation point, where the colour shift actually registers. i18n splits into prefix + link (suffix would be empty), avoiding the sentence-order brittleness that 3-key splits usually introduce. Co-Authored-By: Claude Opus 4.7 Co-authored-by: multica-agent --- packages/views/locales/en/modals.json | 4 ++-- packages/views/locales/zh-Hans/modals.json | 4 ++-- packages/views/modals/feedback.tsx | 23 +++++++++++----------- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/packages/views/locales/en/modals.json b/packages/views/locales/en/modals.json index cbe3237b2..882491418 100644 --- a/packages/views/locales/en/modals.json +++ b/packages/views/locales/en/modals.json @@ -22,7 +22,6 @@ }, "feedback": { "title": "Feedback", - "description": "We'd love to hear what's working, what isn't, or what you'd like to see next.", "placeholder": "Tell us about your experience, bugs you've found, or features you'd like to see…", "toast_uploading": "Please wait for uploads to finish…", "toast_too_long": "Message is too long", @@ -30,7 +29,8 @@ "toast_failed": "Failed to send feedback", "send": "Send feedback", "sending": "Sending…", - "github_hint": "Want to discuss or get faster traction? Open an issue on GitHub →" + "github_hint_prefix": "Want faster traction? Head to ", + "github_hint_link": "GitHub" }, "issue_picker": { "search_placeholder": "Search issues...", diff --git a/packages/views/locales/zh-Hans/modals.json b/packages/views/locales/zh-Hans/modals.json index f2de42047..7330a7672 100644 --- a/packages/views/locales/zh-Hans/modals.json +++ b/packages/views/locales/zh-Hans/modals.json @@ -22,7 +22,6 @@ }, "feedback": { "title": "反馈", - "description": "告诉我们哪些好用、哪些不好用、希望接下来做什么。", "placeholder": "聊聊你的体验、遇到的 bug,或想看到的功能...", "toast_uploading": "请等待上传完成...", "toast_too_long": "内容过长", @@ -30,7 +29,8 @@ "toast_failed": "发送反馈失败", "send": "发送反馈", "sending": "发送中...", - "github_hint": "想要讨论或更快的处理?来 GitHub 提 issue →" + "github_hint_prefix": "想要更快的,请去 ", + "github_hint_link": "GitHub" }, "issue_picker": { "search_placeholder": "搜索 issue...", diff --git a/packages/views/modals/feedback.tsx b/packages/views/modals/feedback.tsx index 93884acb7..912b37e48 100644 --- a/packages/views/modals/feedback.tsx +++ b/packages/views/modals/feedback.tsx @@ -5,7 +5,6 @@ import { toast } from "sonner"; import { Dialog, DialogContent, - DialogDescription, DialogHeader, DialogTitle, } from "@multica/ui/components/ui/dialog"; @@ -93,17 +92,17 @@ export function FeedbackModal({ onClose }: { onClose: () => void }) { {t(($) => $.feedback.title)} - - {t(($) => $.feedback.description)} - - - {t(($) => $.feedback.github_hint)} - +

+ {t(($) => $.feedback.github_hint_prefix)} + + {t(($) => $.feedback.github_hint_link)} + +