From e3ebf317aedaba42e1acfde08b3b49b194bd5393 Mon Sep 17 00:00:00 2001 From: YYClaw <197375+yyclaw@users.noreply.github.com> Date: Thu, 23 Jul 2026 16:35:22 +0800 Subject: [PATCH] fix(i18n): capitalize on-behalf-of attribution label (MUL-5026) (#5670) --- .../views/issues/components/attribution-badge.test.tsx | 10 +++++----- packages/views/locales/en/issues.json | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/views/issues/components/attribution-badge.test.tsx b/packages/views/issues/components/attribution-badge.test.tsx index c63de389f..58be0ea7f 100644 --- a/packages/views/issues/components/attribution-badge.test.tsx +++ b/packages/views/issues/components/attribution-badge.test.tsx @@ -31,7 +31,7 @@ describe("AttributionBadge", () => { }; renderWithI18n(); - expect(screen.getByText("on behalf of Ada Lovelace")).toBeInTheDocument(); + expect(screen.getByText("On behalf of Ada Lovelace")).toBeInTheDocument(); expect(screen.getByTitle("Direct member action")).toBeInTheDocument(); }); @@ -45,7 +45,7 @@ describe("AttributionBadge", () => { , ); - expect(screen.getByText("on behalf of Grace")).toBeInTheDocument(); + expect(screen.getByText("On behalf of Grace")).toBeInTheDocument(); expect(container.querySelector(".text-warning")).not.toBeNull(); expect(screen.getByTitle("No precise owner — attributed to the agent owner")) .toBeInTheDocument(); @@ -64,7 +64,7 @@ describe("AttributionBadge", () => { , ); - expect(screen.getByText("on behalf of Bohan")).toBeInTheDocument(); + expect(screen.getByText("On behalf of Bohan")).toBeInTheDocument(); // No warning tone — the confusing yellow that flagged backfilled runs is gone. expect(container.querySelector(".text-warning")).toBeNull(); expect(container.querySelector(".text-muted-foreground")).not.toBeNull(); @@ -93,7 +93,7 @@ describe("AttributionBadge", () => { }; renderWithI18n(); - expect(screen.getByText("on behalf of someone")).toBeInTheDocument(); + expect(screen.getByText("On behalf of someone")).toBeInTheDocument(); }); it("renders nothing when no responsible member resolved (MUL-4765)", () => { @@ -134,7 +134,7 @@ describe("AttributionBadge", () => { // Only the avatar (name plumbs through the stub) — no "on behalf of" chip. expect(screen.getByTestId("actor-avatar")).toHaveTextContent("Ada Lovelace"); - expect(screen.queryByText("on behalf of Ada Lovelace")).toBeNull(); + expect(screen.queryByText("On behalf of Ada Lovelace")).toBeNull(); }); it("avatar variant renders nothing without an accountable member", () => { diff --git a/packages/views/locales/en/issues.json b/packages/views/locales/en/issues.json index 1197ac8ac..a134dac31 100644 --- a/packages/views/locales/en/issues.json +++ b/packages/views/locales/en/issues.json @@ -482,7 +482,7 @@ "status_failed": "Failed", "status_cancelled": "Cancelled", "attribution": { - "on_behalf_of": "on behalf of {{name}}", + "on_behalf_of": "On behalf of {{name}}", "someone": "someone", "source_direct_human": "Direct member action", "source_delegation": "Delegated from another run",