From f52a2376081eb4356396f3d7deac2adb8997c01c Mon Sep 17 00:00:00 2001 From: Lambda Date: Wed, 17 Jun 2026 00:45:41 +0800 Subject: [PATCH] feat(issues): unify trigger chip copy to will-start phrasing Make the comment trigger chip's on/off states symmetric around the verb 'start' instead of mixing natural language with the 'trigger' jargon: - on: Will start when sent - skipped: Won't start this time - all skipped: No agents will start - multi on: N agents will start when sent Updates all four locales (en/zh-Hans/ja/ko); CJK on-state copy already reads as future-conditional so only the skip states are realigned to the 'start' verb. Updates the component test expectations to match. Refs MUL-3211 Co-authored-by: multica-agent --- .../issues/components/comment-trigger-chips.test.tsx | 10 +++++----- packages/views/locales/en/issues.json | 10 +++++----- packages/views/locales/ja/issues.json | 4 ++-- packages/views/locales/ko/issues.json | 4 ++-- packages/views/locales/zh-Hans/issues.json | 4 ++-- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/views/issues/components/comment-trigger-chips.test.tsx b/packages/views/issues/components/comment-trigger-chips.test.tsx index 26c7dfade..07afeafaa 100644 --- a/packages/views/issues/components/comment-trigger-chips.test.tsx +++ b/packages/views/issues/components/comment-trigger-chips.test.tsx @@ -45,7 +45,7 @@ describe("CommentTriggerChips", () => { ); const chip = screen.getByRole("button"); - expect(chip).toHaveTextContent("Starts working when sent"); + expect(chip).toHaveTextContent("Will start when sent"); expect(chip).toHaveAttribute("aria-pressed", "false"); fireEvent.click(chip); @@ -62,7 +62,7 @@ describe("CommentTriggerChips", () => { ); const chip = screen.getByRole("button"); - expect(chip).toHaveTextContent("Won't be triggered"); + expect(chip).toHaveTextContent("Won't start this time"); expect(chip).toHaveAttribute("aria-pressed", "true"); }); @@ -75,7 +75,7 @@ describe("CommentTriggerChips", () => { />, ); - expect(screen.getByRole("button")).toHaveTextContent("2 agents start working when sent"); + expect(screen.getByRole("button")).toHaveTextContent("2 agents will start when sent"); }); it("counts only non-suppressed agents in the sentence", () => { @@ -87,7 +87,7 @@ describe("CommentTriggerChips", () => { />, ); - expect(screen.getByRole("button")).toHaveTextContent("1 agent starts working when sent"); + expect(screen.getByRole("button")).toHaveTextContent("1 agent will start when sent"); }); it("switches to the none-will-trigger state when every agent is suppressed", () => { @@ -99,7 +99,7 @@ describe("CommentTriggerChips", () => { />, ); - expect(screen.getByRole("button")).toHaveTextContent("No agents will be triggered"); + expect(screen.getByRole("button")).toHaveTextContent("No agents will start"); }); it("opens the popover on click and toggles a row", () => { diff --git a/packages/views/locales/en/issues.json b/packages/views/locales/en/issues.json index e6beca154..83ad4b360 100644 --- a/packages/views/locales/en/issues.json +++ b/packages/views/locales/en/issues.json @@ -280,15 +280,15 @@ "trigger_source_mention_squad_leader": "squad", "trigger_source_unknown": "trigger", "trigger_skipped_label": "Skipped", - "trigger_wont_trigger": "Won't be triggered", - "trigger_none_will_trigger": "No agents will be triggered", + "trigger_wont_trigger": "Won't start this time", + "trigger_none_will_trigger": "No agents will start", "trigger_reason_issue_assignee": "{{name}} is assigned here and will be notified by this comment.", "trigger_reason_mention_agent": "{{name}} is mentioned in this comment.", "trigger_reason_mention_squad_leader": "{{name}} leads a squad mentioned in this comment.", "trigger_reason_unknown": "{{name}} will be triggered by this comment.", - "trigger_will_start": "Starts working when sent", - "trigger_will_start_count_one": "{{count}} agent starts working when sent", - "trigger_will_start_count_other": "{{count}} agents start working when sent", + "trigger_will_start": "Will start when sent", + "trigger_will_start_count_one": "{{count}} agent will start when sent", + "trigger_will_start_count_other": "{{count}} agents will start when sent", "trigger_starts_now": "It will start working right away.", "trigger_starts_when_online": "It is offline now and will start once online.", "trigger_click_to_skip": "Click to skip triggering this time.", diff --git a/packages/views/locales/ja/issues.json b/packages/views/locales/ja/issues.json index b93c50a18..2238410d4 100644 --- a/packages/views/locales/ja/issues.json +++ b/packages/views/locales/ja/issues.json @@ -272,8 +272,8 @@ "trigger_source_mention_squad_leader": "Squad", "trigger_source_unknown": "トリガー", "trigger_skipped_label": "スキップ", - "trigger_wont_trigger": "トリガーされません", - "trigger_none_will_trigger": "いずれもトリガーされません", + "trigger_wont_trigger": "今回は開始しません", + "trigger_none_will_trigger": "いずれも開始しません", "trigger_reason_issue_assignee": "{{name}} はこのイシューの担当で、このコメントで通知されます。", "trigger_reason_mention_agent": "このコメントで {{name}} がメンションされています。", "trigger_reason_mention_squad_leader": "{{name}} はメンションされた Squad のリーダーです。", diff --git a/packages/views/locales/ko/issues.json b/packages/views/locales/ko/issues.json index 4f057e0a2..da4e18cbd 100644 --- a/packages/views/locales/ko/issues.json +++ b/packages/views/locales/ko/issues.json @@ -280,8 +280,8 @@ "trigger_source_mention_squad_leader": "Squad", "trigger_source_unknown": "트리거", "trigger_skipped_label": "건너뜀", - "trigger_wont_trigger": "트리거되지 않습니다", - "trigger_none_will_trigger": "모두 트리거되지 않습니다", + "trigger_wont_trigger": "이번에는 시작하지 않습니다", + "trigger_none_will_trigger": "어떤 에이전트도 시작하지 않습니다", "trigger_reason_issue_assignee": "{{name}}님은 이 이슈의 담당자이며 이 댓글로 알림을 받습니다.", "trigger_reason_mention_agent": "이 댓글에서 {{name}}님을 멘션했습니다.", "trigger_reason_mention_squad_leader": "{{name}}님은 멘션된 Squad의 리더입니다.", diff --git a/packages/views/locales/zh-Hans/issues.json b/packages/views/locales/zh-Hans/issues.json index 6ad3f9f3f..60343749a 100644 --- a/packages/views/locales/zh-Hans/issues.json +++ b/packages/views/locales/zh-Hans/issues.json @@ -277,8 +277,8 @@ "trigger_source_mention_squad_leader": "squad", "trigger_source_unknown": "将触发", "trigger_skipped_label": "已跳过", - "trigger_wont_trigger": "不会触发", - "trigger_none_will_trigger": "全部不会触发", + "trigger_wont_trigger": "本次不会开始", + "trigger_none_will_trigger": "都不会开始", "trigger_reason_issue_assignee": "{{name}} 是当前 issue 的 assignee，这条评论会唤醒它。", "trigger_reason_mention_agent": "这条评论 @ 了 {{name}}。", "trigger_reason_mention_squad_leader": "{{name}} 是被 @ Squad 的 leader。",