From c525a25e518add6cd669c45692ebc0da28a333a2 Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Wed, 15 Jul 2026 08:35:58 +0900 Subject: [PATCH] admin: close the response body on error paths too, and don't use the response body as a format string. --- admin.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/admin.go b/admin.go index be09311..756aabb 100644 --- a/admin.go +++ b/admin.go @@ -132,6 +132,7 @@ var admin = &cli.Command{ continue } b, err := io.ReadAll(resp.Body) + resp.Body.Close() if err != nil { log("failed to read response: %s\n", err) continue @@ -142,7 +143,7 @@ var admin = &cli.Command{ if len(bodyPrintable) > 300 { bodyPrintable = bodyPrintable[0:297] + "..." } - log(bodyPrintable) + log("%s", bodyPrintable) continue } var response nip86.Response @@ -152,10 +153,9 @@ var admin = &cli.Command{ if len(bodyPrintable) > 300 { bodyPrintable = bodyPrintable[0:297] + "..." } - log(bodyPrintable) + log("%s", bodyPrintable) continue } - resp.Body.Close() // print the result log("\n")