From 4129af9205763a113719c7ef102d5c6ff0f1e2e8 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Fri, 27 Jun 2025 11:45:33 -0700 Subject: [PATCH] chore: cleanup comments + unused vars (#11225) --- convert/convert_gemma3n.go | 3 --- model/models/gemma3n/model.go | 1 - 2 files changed, 4 deletions(-) diff --git a/convert/convert_gemma3n.go b/convert/convert_gemma3n.go index bf667e38c..135ebaa55 100644 --- a/convert/convert_gemma3n.go +++ b/convert/convert_gemma3n.go @@ -24,7 +24,6 @@ type gemma3nModel struct { HiddenSize uint32 `json:"hidden_size"` HiddenSizePerLayerInput uint32 `json:"hidden_size_per_layer_input"` IntermediateSize uint32 `json:"intermediate_size"` - LaurelRank uint32 `json:"laurel_rank"` MaxPositionEmbeddings uint32 `json:"max_position_embeddings"` NumAttentionHeads uint32 `json:"num_attention_heads"` NumHiddenLayers uint32 `json:"num_hidden_layers"` @@ -72,8 +71,6 @@ func (m *gemma3nModel) KV(t *Tokenizer) ggml.KV { kv["gemma3n.embedding_length"] = m.TextModel.HiddenSize kv["gemma3n.feed_forward_length"] = m.TextModel.IntermediateSize kv["gemma3n.head_dim"] = m.TextModel.HeadDim - kv["gemma3n.laurel_rank"] = m.TextModel.LaurelRank - kv["gemma3n.num_kv_shared_layers"] = m.TextModel.NumKVSharedLayers kv["gemma3n.rope.freq_base_local"] = m.TextModel.RopeLocalBaseFreq kv["gemma3n.rope.freq_base"] = m.TextModel.RopeTheta return kv diff --git a/model/models/gemma3n/model.go b/model/models/gemma3n/model.go index d210ab759..6e83a9724 100644 --- a/model/models/gemma3n/model.go +++ b/model/models/gemma3n/model.go @@ -39,7 +39,6 @@ func New(c fs.Config) (model.Model, error) { ), } - // TODO: setup hybrid (local sliding window + global) cache m.Cache = kvcache.NewWrapperCache( kvcache.NewCausalCache(m.Shift), kvcache.NewSWACache(int32(c.Uint("attention.sliding_window")), m.Shift),