From 475333d533e088538e5d77c0ba65ea60833b2c77 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Fri, 31 Jan 2025 14:25:49 -0800 Subject: [PATCH] fix docker build-args env context is not accessible from job.*.strategy. since it's in the environment, just tell docker to use the environment variable[1] [1]: https://docs.docker.com/reference/cli/docker/buildx/build/#build-arg --- .github/workflows/release.yaml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 6f0706e4d..e9d8f7218 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -312,16 +312,18 @@ jobs: - flavor: 'latest=false' platforms: linux/amd64,linux/arm64 build-args: | - CGO_CFLAGS=${{ env.CGO_CFLAGS }} - CGO_CXXFLAGS=${{ env.CGO_CXXFLAGS }} - GOFLAGS=${{ needs.setup-environment.outputs.GOFLAGS }} + CGO_CFLAGS + CGO_CXXFLAGS + GOFLAGS - flavor: 'latest=false,suffix=rocm' platforms: linux/amd64 build-args: | - CGO_CFLAGS=${{ env.CGO_CFLAGS }} - CGO_CXXFLAGS=${{ env.CGO_CXXFLAGS }} + CGO_CFLAGS + CGO_CXXFLAGS + GOFLAGS FLAVOR=rocm - GOFLAGS=${{ needs.setup-environment.outputs.GOFLAGS }} + env: + GOFLAGS: ${{ needs.setup-environment.outputs.GOFLAGS }} runs-on: linux environment: release needs: setup-environment