From 592d21e7dbffff5bd4c285503a44d87ffaa6fd1b Mon Sep 17 00:00:00 2001 From: Jesse Gross Date: Fri, 27 Jun 2025 16:19:44 -0700 Subject: [PATCH] Revert "ggml: Temporarily disable reporting UUIDs" The root cause was an unclean upgrade - this code is fine. This reverts commit 45f216a9c7e65bd30ab0e2b1b9fdb7cb2ad9436d. --- ml/backend/ggml/ggml.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ml/backend/ggml/ggml.go b/ml/backend/ggml/ggml.go index f8727490d7..4f1212de4c 100644 --- a/ml/backend/ggml/ggml.go +++ b/ml/backend/ggml/ggml.go @@ -138,10 +138,7 @@ func New(modelPath string, params ml.BackendParams) (ml.Backend, error) { requiredMemory.CPU.Name = C.GoString(C.ggml_backend_dev_name(cpuDeviceBufferType.d)) var props C.struct_ggml_backend_dev_props C.ggml_backend_dev_get_props(cpuDeviceBufferType.d, &props) - - // Bug #11211: Reporting of UUIDs is temporarily disabled due to causing segfaults - // This only affects debug information until the new memory management code is in place - // requiredMemory.CPU.UUID = C.GoString(props.uuid) + requiredMemory.CPU.UUID = C.GoString(props.uuid) requiredMemory.CPU.Weights = make([]ml.Memory, blocks+1) requiredMemory.CPU.Cache = make([]ml.Memory, blocks+1) @@ -158,7 +155,7 @@ func New(modelPath string, params ml.BackendParams) (ml.Backend, error) { requiredMemory.GPUs[i].Name = C.GoString(C.ggml_backend_dev_name(d)) var props C.struct_ggml_backend_dev_props C.ggml_backend_dev_get_props(d, &props) - // requiredMemory.GPUs[i].UUID = C.GoString(props.uuid) + requiredMemory.GPUs[i].UUID = C.GoString(props.uuid) requiredMemory.GPUs[i].Weights = make([]ml.Memory, blocks+1) requiredMemory.GPUs[i].Cache = make([]ml.Memory, blocks+1) }