From 83f0ec8269eeaaef993af5b61916919db34e8cb7 Mon Sep 17 00:00:00 2001 From: jmorganca Date: Tue, 11 Mar 2025 19:00:13 +0100 Subject: [PATCH] all: address linter errors --- convert/convert.go | 1 - model/models/gemma3/model_vision.go | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/convert/convert.go b/convert/convert.go index 4467f9e1b..7b9fe31ff 100644 --- a/convert/convert.go +++ b/convert/convert.go @@ -228,7 +228,6 @@ func ConvertModel(fsys fs.FS, ws io.WriteSeeker) error { switch { case vocabSize == 0: slog.Warn("vocabulary size was not explicitly set by the model", "default size", len(t.Vocabulary.Tokens)) - vocabSize = len(t.Vocabulary.Tokens) case vocabSize > len(t.Vocabulary.Tokens): slog.Warn("vocabulary is smaller than expected, padding with dummy tokens", "expect", vocabSize, "actual", len(t.Vocabulary.Tokens)) for i := range vocabSize - len(t.Vocabulary.Tokens) { diff --git a/model/models/gemma3/model_vision.go b/model/models/gemma3/model_vision.go index a508f65bd..94aa27bd7 100644 --- a/model/models/gemma3/model_vision.go +++ b/model/models/gemma3/model_vision.go @@ -69,9 +69,9 @@ func (e *VisionEncoderLayer) Forward(ctx ml.Context, hiddenState ml.Tensor, opts } type VisionModelOptions struct { - hiddenSize, numHeads, numTiles int - imageSize, patchSize int - eps float32 + hiddenSize, numHeads int + imageSize, patchSize int + eps float32 } type VisionModel struct {