From c563286e63748b9b61d014ca44d006bde230780b Mon Sep 17 00:00:00 2001 From: nicole pardal Date: Tue, 21 Oct 2025 13:57:01 -0700 Subject: [PATCH] simplfied logic and added tests --- middleware/openai.go | 3 +-- openai/openai.go | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/middleware/openai.go b/middleware/openai.go index 863ece2217..b2e43f165c 100644 --- a/middleware/openai.go +++ b/middleware/openai.go @@ -256,8 +256,7 @@ func (w *EmbedWriter) writeResponse(data []byte) (int, error) { } w.ResponseWriter.Header().Set("Content-Type", "application/json") - converted := openai.ToEmbeddingList(w.model, embedResponse, w.encodingFormat) - err = json.NewEncoder(w.ResponseWriter).Encode(converted) + err = json.NewEncoder(w.ResponseWriter).Encode(openai.ToEmbeddingList(w.model, embedResponse, w.encodingFormat)) if err != nil { return 0, err } diff --git a/openai/openai.go b/openai/openai.go index a779ef8990..650514cf19 100644 --- a/openai/openai.go +++ b/openai/openai.go @@ -383,15 +383,11 @@ func ToListCompletion(r api.ListResponse) ListCompletion { // encodingFormat can be "float", "base64", or empty (defaults to "float") func ToEmbeddingList(model string, r api.EmbedResponse, encodingFormat string) EmbeddingList { if r.Embeddings != nil { - if encodingFormat == "" { - encodingFormat = "float" - } - var data []Embedding for i, e := range r.Embeddings { var embedding any - if encodingFormat == "base64" { - embedding = convertFloatsToBase64(e) + if strings.EqualFold(encodingFormat, "base64") { + embedding = floatsToBase64(e) } else { embedding = e }