From d6af13efedb5c211589af0c2a6ad6fe1491bf302 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Wed, 26 Feb 2025 15:16:22 -0800 Subject: [PATCH] runner: simplify tensor split parsing --- runner/llamarunner/runner.go | 9 ++++----- runner/ollamarunner/runner.go | 9 ++++----- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/runner/llamarunner/runner.go b/runner/llamarunner/runner.go index f9d204015..1afc793ef 100644 --- a/runner/llamarunner/runner.go +++ b/runner/llamarunner/runner.go @@ -943,12 +943,11 @@ func Execute(args []string) error { var tensorSplitFloats []float32 if *tensorSplit != "" { - stringFloats := regexp.MustCompile(",").Split(*tensorSplit, -1) - - tensorSplitFloats = make([]float32, 0, len(stringFloats)) - for _, s := range stringFloats { + splits := strings.Split(*tensorSplit, ",") + tensorSplitFloats = make([]float32, len(splits)) + for i, s := range splits { f, _ := strconv.ParseFloat(s, 32) - tensorSplitFloats = append(tensorSplitFloats, float32(f)) + tensorSplitFloats[i] = float32(f) } } diff --git a/runner/ollamarunner/runner.go b/runner/ollamarunner/runner.go index d39981204..b39d747f8 100644 --- a/runner/ollamarunner/runner.go +++ b/runner/ollamarunner/runner.go @@ -881,12 +881,11 @@ func Execute(args []string) error { var tensorSplitFloats []float32 if *tensorSplit != "" { - stringFloats := regexp.MustCompile(",").Split(*tensorSplit, -1) - - tensorSplitFloats = make([]float32, 0, len(stringFloats)) - for _, s := range stringFloats { + splits := strings.Split(*tensorSplit, ",") + tensorSplitFloats = make([]float32, len(splits)) + for i, s := range splits { f, _ := strconv.ParseFloat(s, 32) - tensorSplitFloats = append(tensorSplitFloats, float32(f)) + tensorSplitFloats[i] = float32(f) } }