diff --git a/harmony/harmonyparser.go b/harmony/harmonyparser.go index b365b763d8..da9fe3e938 100644 --- a/harmony/harmonyparser.go +++ b/harmony/harmonyparser.go @@ -463,6 +463,10 @@ func (h *HarmonyMessageHandler) HasThinkingSupport() bool { func (m *FunctionNameMap) ConvertAndAdd(userFunctionName string) string { harmonyFunctionName := m.deriveName(userFunctionName) + // built-in functions should not be renamed + if userFunctionName == "browser.open" || userFunctionName == "browser.search" || userFunctionName == "browser.find" || userFunctionName == "python" { + harmonyFunctionName = userFunctionName + } m.userToHarmony[userFunctionName] = harmonyFunctionName m.harmonyToUser[harmonyFunctionName] = userFunctionName return harmonyFunctionName diff --git a/harmony/harmonyparser_test.go b/harmony/harmonyparser_test.go index b988a018f3..e56178c61d 100644 --- a/harmony/harmonyparser_test.go +++ b/harmony/harmonyparser_test.go @@ -513,6 +513,7 @@ func TestFunctionConvertAndAdd(t *testing.T) { {name: "dupes from different user-specified names", in: []string{"get weather", "get_weather", "get-weather"}, want: []string{"get_weather", "get_weather_2", "get_weather_3"}}, {name: "non dupes after dupes", in: []string{"get weather", "get_weather", "get-weather", "something-different"}, want: []string{"get_weather", "get_weather_2", "get_weather_3", "something_different"}}, {name: "multiple sets of dupes", in: []string{"a", "a", "b", "a", "a", "b", "a"}, want: []string{"a", "a_2", "b", "a_3", "a_4", "b_2", "a_5"}}, + {name: "built-in functions should not be renamed", in: []string{"browser.open", "python", "not.a.built-in.function", "browser.not_a_real_built_in"}, want: []string{"browser.open", "python", "not_a_built_in_function", "browser_not_a_real_built_in"}}, } for i, tt := range tests {