From 0586d76b5d67c4c7f95053becd20eb734bea3d32 Mon Sep 17 00:00:00 2001 From: Justin Hayes Date: Mon, 3 Jun 2024 16:26:30 -0400 Subject: [PATCH 1/2] Add line re: keeping PRs open --- docs/CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 3e82c979c..92238d307 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -45,6 +45,7 @@ We welcome pull requests. Before submitting one, please: 2. Follow the project's coding standards and include tests for new features. 3. Update documentation as necessary. 4. Write clear, descriptive commit messages. +5. It's essential to complete your pull request in a timely manner. We move fast, and having PRs hang around too long is not feasible. If you can't get it done within a reasonable time frame, we may have to close it to keep the project moving forward. ### 📚 Documentation & Tutorials From 58b5e0bf3e8c8652c7800bc3ff0e1684636fb055 Mon Sep 17 00:00:00 2001 From: "Timothy J. Baek" Date: Mon, 3 Jun 2024 13:35:03 -0700 Subject: [PATCH 2/2] fix: modelfile edit --- src/routes/(app)/workspace/models/edit/+page.svelte | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/routes/(app)/workspace/models/edit/+page.svelte b/src/routes/(app)/workspace/models/edit/+page.svelte index 56a0ad387..4dc13441b 100644 --- a/src/routes/(app)/workspace/models/edit/+page.svelte +++ b/src/routes/(app)/workspace/models/edit/+page.svelte @@ -113,7 +113,11 @@ } params = { ...params, ...model?.info?.params }; - params.stop = params?.stop ? (params?.stop ?? []).join(',') : null; + params.stop = params?.stop + ? (typeof params.stop === 'string' ? params.stop.split(',') : params?.stop ?? []).join( + ',' + ) + : null; if (model?.owned_by === 'openai') { capabilities.usage = false;