From 33f1a1609455ed78f19178367056fd63d77d1951 Mon Sep 17 00:00:00 2001
From: WillyJL <49810075+Willy-JL@users.noreply.github.com>
Date: Mon, 23 Dec 2024 01:52:37 +0100
Subject: [PATCH] FBT: Don't lint JS packages (#4030)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: あく <alleteam@gmail.com>
---
 firmware.scons  |  2 ++
 scripts/lint.py | 26 ++++++++++++++++++--------
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/firmware.scons b/firmware.scons
index 4c5e05873..e7378f957 100644
--- a/firmware.scons
+++ b/firmware.scons
@@ -29,6 +29,8 @@ env = ENV.Clone(
     TARGETS_ROOT=Dir("#/targets"),
     LINT_SOURCES=[
         Dir("applications"),
+        # Not C code
+        Dir("!applications/system/js_app/packages"),
     ],
     LIBPATH=[
         "${LIB_DIST_DIR}",
diff --git a/scripts/lint.py b/scripts/lint.py
index 8530209be..896cd3812 100755
--- a/scripts/lint.py
+++ b/scripts/lint.py
@@ -35,21 +35,25 @@ class Main(App):
         self.parser_format.set_defaults(func=self.format)
 
     @staticmethod
-    def _filter_lint_directories(dirnames: list[str]):
+    def _filter_lint_directories(
+        dirpath: str, dirnames: list[str], excludes: tuple[str]
+    ):
         # Skipping 3rd-party code - usually resides in subfolder "lib"
         if "lib" in dirnames:
             dirnames.remove("lib")
-        # Skipping hidden folders
+        # Skipping hidden and excluded folders
         for dirname in dirnames.copy():
             if dirname.startswith("."):
                 dirnames.remove(dirname)
+            if os.path.join(dirpath, dirname).startswith(excludes):
+                dirnames.remove(dirname)
 
-    def _check_folders(self, folders: list):
+    def _check_folders(self, folders: list, excludes: tuple[str]):
         show_message = False
         pattern = re.compile(SOURCE_CODE_DIR_PATTERN)
         for folder in folders:
             for dirpath, dirnames, filenames in os.walk(folder):
-                self._filter_lint_directories(dirnames)
+                self._filter_lint_directories(dirpath, dirnames, excludes)
 
                 for dirname in dirnames:
                     if not pattern.match(dirname):
@@ -61,11 +65,11 @@ class Main(App):
                 "Folders are not renamed automatically, please fix it by yourself"
             )
 
-    def _find_sources(self, folders: list):
+    def _find_sources(self, folders: list, excludes: tuple[str]):
         output = []
         for folder in folders:
             for dirpath, dirnames, filenames in os.walk(folder):
-                self._filter_lint_directories(dirnames)
+                self._filter_lint_directories(dirpath, dirnames, excludes)
 
                 for filename in filenames:
                     ext = os.path.splitext(filename.lower())[1]
@@ -168,14 +172,20 @@ class Main(App):
 
     def _perform(self, dry_run: bool):
         result = 0
-        sources = self._find_sources(self.args.input)
+        excludes = []
+        for folder in self.args.input.copy():
+            if folder.startswith("!"):
+                excludes.append(folder.removeprefix("!"))
+                self.args.input.remove(folder)
+        excludes = tuple(excludes)
+        sources = self._find_sources(self.args.input, excludes)
         if not self._format_sources(sources, dry_run=dry_run):
             result |= 0b001
         if not self._apply_file_naming_convention(sources, dry_run=dry_run):
             result |= 0b010
         if not self._apply_file_permissions(sources, dry_run=dry_run):
             result |= 0b100
-        self._check_folders(self.args.input)
+        self._check_folders(self.args.input, excludes)
         return result
 
     def check(self):